Skip to content

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Jul 8, 2019

Ran script from MS Docs Authoring Pack.

  • HTTP -> HTTPS
  • Removes link locale

@ktoliver
Copy link
Contributor

ktoliver commented Jul 8, 2019

@craigg-msft @MikeRayMSFT @rothja @MightyPen - Could you review the PR? If you accept the submission, PR reviewers can move the commit to the private repo for validation and staging. Thanks.

@ktoliver ktoliver added the aq-pr-triaged tracking label for the PR review team label Jul 8, 2019
@MightyPen MightyPen requested a review from v-thepet July 9, 2019 01:33
@MightyPen MightyPen self-assigned this Jul 9, 2019
@MightyPen
Copy link
Contributor

@nschonni Hi Nick, This public PR 2451 looks pretty good. I looked through about 25% of it. The hassle is that the GitHub Differ often tells us only that there was a change somewhere in this or that large paragraph; without highlighting the changed characters in the paragraph. It is therefore a tiring challenge for the human eye to be thorough.
We are considering approving this PR.

@v-thepet Hi Theano, This PR 2451 could be closely related to CATS work you had been doing. Could you spend 5-10 minutes looking at this 'Files changed' tab, and then enter a new Comment here to say whether your samplings suggest we Approve vs Disapprove? If you cannot work on this type of PR, I will understand, just tell me so. Thanks.

@nschonni
Copy link
Contributor Author

nschonni commented Jul 9, 2019

@rothja
Copy link
Collaborator

rothja commented Jul 30, 2019

@v-thepet Theano, have you had a chance to look at Gene's question on this PR? Thanks!

@MikeRayMSFT
Copy link
Contributor

Due to the many merge conflicts, I think we'll need to close this, and run again in a new copy of the repository. @nschonni could you do that, and open a new PR? I'll watch for it and review it quickly.

@nschonni
Copy link
Contributor Author

I'll rebase this and ping you when I'm home

Ran script from MS Docs Authoring Pack.
- HTTP -> HTTPS
- Removes link locale
@nschonni nschonni force-pushed the chore--Cleanup-Microsoft-links branch from ca5f49d to e2dadb4 Compare August 12, 2019 22:26
@nschonni
Copy link
Contributor Author

@MikeRayMSFT I've rebase this and force pushed to resolve the conflicts

@ktoliver
Copy link
Contributor

We're in the process of pulling these commits to the private repo, so we can verify the content on staging. We'll post a new PR # shortly and then close this PR.

@ktoliver
Copy link
Contributor

@nschonni @MightyPen @MikeRayMSFT @rothja - Private repo PR 11506 replaces this PR. We'll validate the updated URLs on staging in the private repo PR and reach out to content owners if needed. We'll close this PR now. Thanks!

@ktoliver ktoliver closed this Aug 13, 2019
@nschonni nschonni deleted the chore--Cleanup-Microsoft-links branch August 13, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aq-pr-triaged tracking label for the PR review team do-not-merge review-team-triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants