Update CI for WinUI 3 instructions to not use solution name for upload #4346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chingucoding : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 9a19707: ✅ Validation status: passed
For more details, please refer to the build report. Note: Links can become broken if there are changes on the target sites. For any questions, please:
|
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
|
Learn Build status updates of commit ff065f5: ✅ Validation status: passed
For more details, please refer to the build report. Note: Links can become broken if there are changes on the target sites. For any questions, please:
|
learn-build-service-prod bot
added a commit
that referenced
this pull request
May 28, 2024
…c_temp For protected branch, push strategy should use PR and merge to target branch method to work around git push error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue with the GitHub Action step uploading the artifact since it uses the solution name as part of the path. In almost all cases, the build output does not land in a folder that contains the solution name including the
.sln. This PR updates this to the GitHub actions Workspace folder.