Skip to content

Conversation

citelao
Copy link
Contributor

@citelao citelao commented Dec 13, 2023

Today, our documentation incorrectly claims that custom attached properties cannot be set in XAML markup if they were implemented in C++/WinRT. This change updates our documentation to correct the mistake.

What changed?

  • Removed C++/WinRT callouts
  • Added note about this change, since it is subtle.

Why?

We tested this locally; we have a custom attached property & it works just fine in XAML markup (internal PR link).

Copy link
Contributor

@citelao : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 16607d1:

✅ Validation status: passed

File Status Preview URL Details
uwp/xaml-platform/custom-attached-properties.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@stevewhims
Copy link
Member

I'll take this. The topic is assigned to Jim, but I added this content (back when it was true). :)

@stevewhims
Copy link
Member

I've removed the bit saying that the topic was previously incorrect. We update content all the time when the platform changes (as in this case), and we make corrections to content all the time. So if we left "this topic was previously wrong about" messages each time we did that, the topic would say little else. :)

Copy link
Contributor

Learn Build status updates of commit 80eab9a:

✅ Validation status: passed

File Status Preview URL Details
uwp/xaml-platform/custom-attached-properties.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@stevewhims stevewhims merged commit 2c0060e into MicrosoftDocs:docs Dec 13, 2023
@citelao
Copy link
Contributor Author

citelao commented Dec 13, 2023

Thanks, @stevewhims! I wasn't sure if it had changed or if it was a doc bug. Your edits are fine :).

learn-build-service-prod bot pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants