Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feedback] Command Palette experiment #73

Closed
captainbrosset opened this issue Jun 22, 2022 · 38 comments
Closed

[feedback] Command Palette experiment #73

captainbrosset opened this issue Jun 22, 2022 · 38 comments
Labels
feedback Feedback about an existing DevTools feature

Comments

@captainbrosset
Copy link
Contributor

captainbrosset commented Jun 22, 2022

This issue is meant to collect feedback about the Edge Command Palette experiment.

Edge Command Palette is a new experiment that makes it possible to run useful productivity and developer commands in Edge by pressing Ctrl+Q. This includes running DevTools commands without having to open DevTools first. Learn more about this experiment and how to use it from the documentation.

If you used Edge Command Palette and have any feedback about it, please leave a comment in this issue.

Shortcut note: the experiment started with the Ctrl+Shift+Space shortcut and that shortcut works in Microsoft Edge 105 to 107. Based on feedback received in this issue, it was changed to Ctrl+Q and this shortcut can be used starting with Microsoft Edge 108.

@captainbrosset captainbrosset added the feedback Feedback about an existing DevTools feature label Jun 22, 2022
@captainbrosset captainbrosset pinned this issue Jul 7, 2022
@codepo8
Copy link
Contributor

codepo8 commented Jul 8, 2022

One of the things I am missing is direct interaction. You can open DevTools from it and use some of the functionaliity there but often I don't want to do that. I'd love to see some immediate toggles being available through the command palette:

  • Turn JavaScript on/off
  • Switch dark/light mode of the current page (this is part of the rendering tool)
  • Take full page screenshot (this is available as cmd+shift+s but people may not know it)
  • Show/hide keyboard order (this is part of the accessibility panel)

@raekul
Copy link

raekul commented Jul 11, 2022

Saw and tried out, found some issues.

Machine SurfaceBook 2
Edition Windows 11 Enterprise
OS build 22000.739
Edge (beta) Version 104.0.1293.14

  1. (with dark mode) Loading the palette each time, palette flashes in light mode then loads in the correct theme
  2. (with dark mode) Similar to the above, when typing out queries, when suggestions enter/leave, they sometimes can cause individual suggestions or the entire suggestions panel to re-render in what looks like "light mode" then back to the theme.
  3. Suggestions and or input field get cut off in certain cases (see screenshot below)
    • Second screenshot is upon navigating into the suggestions with arrow keys
  4. Typing can feel a bit sluggish and un-responsive, at times, it's minimal, but I would expect perhaps a slight delay on the suggestions instead of typing 🙂

image for item 3 above

second image for item 3 above

@raekul
Copy link

raekul commented Jul 11, 2022

An additional comment, this feature is inaccessible for screen reader users and has issues.

  1. Upon opening the combo box, it announces that there are suggestions, but there are zero present, this leads users to believe they can start navigating straight away.
  2. The combobox informs the user it has finished loading on mount with the following verbatim prompt "Quick Commands has finished loading." however, this could be more meaningful to users, perhaps "Quick commands is loaded, start typing" so it indicates what their next action could be?
  3. Upon mount, the combobox receives focus but the user is unable to type in the box at all.

NarratorBuddy output

No next table
No next edit box
Unavailable
No next table
Unavailable
No next edit box
Unavailable
No next paragraph

@ngaitonde
Copy link
Member

@raekul the work to make this UI accessible to Screen Readers is planned for us. Thank you for trying out the feature and providing your feedback.

@whl83111
Copy link

The shortcut Ctrl+Shift+Space is conflicted with macOS's change input method shortcut (Ctrl+Space), and won't work until I change the input method shortcut.

@codepo8
Copy link
Contributor

codepo8 commented Jul 19, 2022

The shortcut Ctrl+Shift+Space is conflicted with macOS's change input method shortcut (Ctrl+Space), and won't work until I change the input method shortcut.

How does that work? I am a MacOS user and never triggered that. Do you need an external keyboard?

@whl83111
Copy link

The shortcut Ctrl+Shift+Space is conflicted with macOS's change input method shortcut (Ctrl+Space), and won't work until I change the input method shortcut.

How does that work? I am a MacOS user and never triggered that. Do you need an external keyboard?

Yes, I'm using an external keyboard, but I also tried the macbook built-in keyboard, doesn't work either.

Here are the versions:
macOS 12.4
edge 105.0.1321.0

@bradleypatton
Copy link

The shortcut Ctrl+Shift+Space is not working on my desktop (Windows 11) either in Edge dev or release. Not sure if another app is capturing it. I do have Power Toys installed but it doesn't seem to trigger anything when I press that combination. Is there a way to alter the key combo or see what is capturing that combo?

@codepo8
Copy link
Contributor

codepo8 commented Jul 20, 2022

The shortcut Ctrl+Shift+Space is not working on my desktop (Windows 11) either in Edge dev or release. Not sure if another app is capturing it. I do have Power Toys installed but it doesn't seem to trigger anything when I press that combination. Is there a way to alter the key combo or see what is capturing that combo?

This is currently only enabled in Canary, not in Dev yet.

@danieltharris
Copy link

I’d like to suggest the shortcut being changed to Ctrl + Shift + P so that it matches tooling such as VS Code and Windows Terminal.

I feel like it would just make sense to keep them similar, especially since it's mainly power users / developers who will use the feature and they're already used to that shortcut.

@pixiekat
Copy link

pixiekat commented Aug 3, 2022

Just enabled it and it works great, the only thing I noticed is that when first set up, it conflicts with the standard 1Password Quick Actions shortcut so I had to disable that first before I could use it.

Also adding the ability to take a full page screenshot would be great.

@codepo8
Copy link
Contributor

codepo8 commented Aug 3, 2022

Just enabled it and it works great, the only thing I noticed is that when first set up, it conflicts with the standard 1Password Quick Actions shortcut so I had to disable that first before I could use it.

Also adding the ability to take a full page screenshot would be great.

Thanks so much for your feedback. Good catch with the 1Password extension - I guess it is tough to find any keyboard shortcut that isn't used yet.

As for the full page screenshot, I suppose you mean one that also scrolls the whole document, right?

This is already in device mode, so it should be easy to add.

However, Ctrl+Shift+S also offers you a full screen screenshot.

menu item in device mode offering full screen screenshot

@Nova38
Copy link

Nova38 commented Aug 28, 2022

I am having the same issue with the onepass extension. Is there a way to remap the edge keyboard shortcut to a different shortcut of the users choice?

@WebMechanic
Copy link

speaking of screenshots... size (height) is limited to 16384px (also in Chrome)

i.e. try full page screenshot of https://css3test.com/
works in FF though

@WebMechanic
Copy link

@Nova38 Is there a way to remap the edge keyboard shortcut to a different shortcut of the users choice?

try edge://extensions/shortcuts

@codepo8
Copy link
Contributor

codepo8 commented Aug 31, 2022

speaking of screenshots... size (height) is limited to 16384px (also in Chrome)

i.e. try full page screenshot of https://css3test.com/ works in FF though

Interesting, I will file a bug and see why this is.

@Nova38
Copy link

Nova38 commented Aug 31, 2022

@Nova38 Is there a way to remap the edge keyboard shortcut to a different shortcut of the users choice?

try edge://extensions/shortcuts

That is only for extensions not for edge shortcuts.

@WebMechanic
Copy link

That is only for extensions not for edge shortcuts.

yes, I thought you might try to change the shortcutss of the onepass extension

@Nova38
Copy link

Nova38 commented Sep 2, 2022

That is only for extensions not for edge shortcuts.

yes, I thought you might try to change the shortcutss of the onepass extension

Ah okay, that shortcut is actually also for the system wide onepass program that integrates with the extension. I would really prefer not to change that as i have been using it for years and it is very convenient. It registers the hotkey globally.

@erdraud
Copy link
Contributor

erdraud commented Sep 15, 2022

@WebMechanic @Nova38 @pixiekat we will be updating the keyboard shortcut, thank you for your feedback!

@captainbrosset
Copy link
Contributor Author

captainbrosset commented Sep 20, 2022

The description at the top of this issue, and the documentation were both updated with the new Ctrl+Q shortcut that can be used starting with Microsoft Edge 108.

@pauljacobson
Copy link

I love this feature in a browser. Vivaldi has a really nice implementation of this sort of feature that I would love to see expanded in Microsoft Edge.

One option I use constantly is the ability to use the command palette to close tabs to the right of my active tab. This seems like a small thing, but it's a huge quality of life feature for me. Here's an example in Vivaldi:

Capture_2022-10-31.at.10.31.28.mp4

Even if the Edge version doesn't explicitly support this option, I'd love to be able to define custom commands and select options like closing tabs to the right of an active tab.

@olifink
Copy link

olifink commented Oct 31, 2022

I’d like to suggest the shortcut being changed to Ctrl + Shift + P so that it matches tooling such as VS Code and Windows Terminal.

I feel like it would just make sense to keep them similar, especially since it's mainly power users / developers who will use the feature and they're already used to that shortcut.

agree - also Edge DevTools has it's own Command Palette on Ctrl-Shift-P which ideally should merge with this new implementation as just one Command Palette exposing DevTools commands when opened

@chrishutchinson
Copy link

Excited about this, lots of potential.

I am keen to add a command palette to my own product, but if we're heading towards a browser standard palette with a global shortcut (a la GitHub and Slack) then I'd rather be able to re-use the native one rather than implement my own in-app one, and register commands from my code (via the manifest.json maybe?) that can appear in the palette. Maybe the > prefix or similar could quick filter to app-specific commands.

@ankitbko
Copy link

One suggestion is to have capability to "Search Tabs" through Command Palette itself instead of having another shortcut for it. Result can be displayed similar to how historical tab search result is displayed.
image

@captainbrosset
Copy link
Contributor Author

One suggestion is to have capability to "Search Tabs" through Command Palette itself instead of having another shortcut for it. Result can be displayed similar to how historical tab search result is displayed.

I agree, having this directly in command palette, instead of having to switch the tab search window, would be a nicer experience.

@MicrosoftEdge MicrosoftEdge deleted a comment from familyFlyss Jan 2, 2023
@lisp719
Copy link

lisp719 commented Feb 21, 2023

If the mouse cursor hovers over the command palette while entering text, it will focus.
I would prefer that text input be the preferred method.

@nathollings
Copy link

nathollings commented May 16, 2023

The ability to change the shortcut would be great.

VsCode has ctrl + p for files and ctrl + shift + p for tools. something like this would be great.
like vscode, if ctrl + p showed the all the tabs in order of recently used that would be great.
a cool feature would be close all tabs. -> which would take you back to the start tab.

@WebMechanic
Copy link

I wouldn't want ctrl + p in the browser window taken over by a feature I probably wouldn't use that often (no matter how useful it seems) as it's been assigned to "Print" since ever and in virtually every application on all systems that access printers.
There are likely as many people that like to "print" (to pdf) and thus want "ctrl+p" to do just that as there are nerds and geeks and self acclaimed power users that like to use it to open a devtools/vscode-like Command Palette and go from there (which always requires two or more steps to perform the most simple task/command).

Different users have different needs, and nobody here is THE ultimate reference user for any app whatsover, so by all means Microsoft: make this shortcut customizable so users can pick whatever they want according to their priority and let's not get into a futile discussion which shortcut is good or not or preferred by anyone.

Once a Command Palette is available I'm confident it can be stuffed with a sorts of features bit by bit 'cos unlike menu items and toolbar buttons it doesn't take any more screen estate to do so.

These features sound interesting to have, their proposed shortcut: not so much :)

  • showed the all the tabs in order of recently used
  • close all tab

Have a nice time.

@martinjanocko
Copy link

Hello, the CTRL + Q shortcut interferes with Outlook web app. Previously you could toggle emails being read/unread and now that's unusable in Edge.

@captainbrosset
Copy link
Contributor Author

Thanks @martinjanocko, for reporting this. Does Ctrl+U works to mark emails as unread? And, what does Ctrl+Q do? Nothing? Open the Command Palette?

I'm asking because it seems to be working for me still. In any tab other than Outlook, Ctrl+Q opens the Command Palette, and in Outlook Ctrl+U and Ctrl+Q mark emails as unread/read without Command Palette interference.

Any extra detail you can share would help us understand the issue and therefore investigate it.

@martinjanocko
Copy link

Since yesterday I had the command palette feature disabled in edge://flags/, but now when I wanted to test it again to be able to reply and enabled it, the CTRL + Q works as expected in OWA. So all good on my side, probably a temporary issue after MS Edge update not really sure what has happened. Sorry for the troubles.

@captainbrosset captainbrosset unpinned this issue Nov 13, 2023
@captainbrosset
Copy link
Contributor Author

Closing this issue. Thank you all for the feedback you have shared here while the issue was open. It helped us a lot work on this experiment.

@jaskp
Copy link

jaskp commented Mar 21, 2024

Is this feature gone? Ctrl+Q doesn't do anything for me on 123.0.2420.51 beta macOS and I can't find the flag in edge://flags anymore either. It's also missing from 124 canary but is still present in 122 stable.

@captainbrosset
Copy link
Contributor Author

Correct, we're removing this experimental feature starting with Microsoft Edge 123. A release note, which mentions this, will be published later today.

@pixiekat
Copy link

Aw, I'm sad to hear this but I know something better will come along with the feedback gathered!

@Relin404
Copy link

This was really one of the top-notch features that made Edge my main browser for a long time. I really hate that it's gone, and I can't see a reason for its demise.

@captainbrosset
Copy link
Contributor Author

@Relin404 this experiment had never made it out of experimental mode, and our team doesn't have capacity to maintain it over time.
I'm curious though, which commands did you used most with it? If what you used most were DevTools commands, you can access them from within DevTools directly by using the Command Menu (Ctrl+Shift+P).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Feedback about an existing DevTools feature
Projects
None yet
Development

No branches or pull requests