Commenting out unnecessary shuffle for testing purposes #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update branch to 2.2rc1
if the folder.conf has SHUFFLE=ON, shuffle is executed while loading the playlist. i don't know, why inc.settingsFolderSpecific.sh is executing shuffle again?!?!? my opinion is, that it is not needed, because the playlist is alread shuffled. For that reason and for testing i uncomment line 53. If everthing is ok, the IF clause could be removed completely.
princemaxwell
changed the title
princemaxwell
changed the title
|
Looks ok to me, but I never touched that file. |
added global + ignore to replace all ";" in the artist, if more than one occurs
MiczFlor
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the folder.conf has SHUFFLE=ON, shuffle is executed while loading the playlist.
i don't know, why inc.settingsFolderSpecific.sh is executing shuffle again?!?!?
my opinion is, that it is not needed, because the playlist is alread shuffled.
For that reason and for testing i comment out line 53. If everthing is ok, the IF clause could be removed completely.