Merge Autohotspot setup into main install script #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docker packages
disable autohotspot service if not selected. remove old docs
reactivate disable powermanagment. update comments. remove obsolete files and calls.
even with multiple invocation we want to keep the first original file. Delete autohotspot service in helperscript
|
Cool! |
Pull Request Test Coverage Report for Build 6707480487
💛 - Coveralls |
|
Good Idea 👍 |
AlvinSchiller
force-pushed
the
feature/mergeAutohotspotScript
branch
2 times, most recently
from
1130e4f
to
747e3fc
Compare
AlvinSchiller
force-pushed
the
feature/mergeAutohotspotScript
branch
from
747e3fc
to
b6a8b71
Compare
Pull Request Test Coverage Report for Build 6714477356
💛 - Coveralls |
Pull Request Test Coverage Report for Build 6726369719
💛 - Coveralls |
Pull Request Test Coverage Report for Build 6754615606
💛 - Coveralls |
moved autohotspot.sh to sampleconfig
AlvinSchiller
force-pushed
the
feature/mergeAutohotspotScript
branch
from
8202747
to
6d96a79
Compare
|
The main installation script currently doesn't perform a "deconfiguration" if run again and choose a different settings (eg. for Wifi or Service activation). So the autohotspot feature is aligned with that. |
on boot or after unblock of wifi the device can give additional errorcodes (-11) this caused incorrectly a hotspot start
AlvinSchiller
force-pushed
the
feature/mergeAutohotspotScript
branch
from
44afe5c
to
35018f5
Compare
AlvinSchiller
force-pushed
the
feature/mergeAutohotspotScript
branch
from
212d493
to
236da57
Compare
also check for hard blocked wifi
AlvinSchiller
force-pushed
the
feature/mergeAutohotspotScript
branch
from
b4afefc
to
ea7a389
Compare
AlvinSchiller
force-pushed
the
feature/mergeAutohotspotScript
branch
from
ee87873
to
cc2e739
Compare
AlvinSchiller
force-pushed
the
feature/mergeAutohotspotScript
branch
from
cc2e739
to
1f5dbcb
Compare
AlvinSchiller
force-pushed
the
feature/mergeAutohotspotScript
branch
from
ad98221
to
213b961
Compare
|
@AlvinSchiller, ready to merge? |
Yep. Nothing more from my side. |
s-martin
approved these changes
Nov 4, 2023
AlvinSchiller
added a commit
to AlvinSchiller/RPi-Jukebox-RFID
that referenced
this pull request
Dec 21, 2023
* merge autohotspot setup into main install script * added autohotspot config step * fix intendation * fix tests * add "iw" to needed packages. Update docker packages * refactored into sample confs. disable autohotspot service if not selected. remove old docs * use crontab command. reactivate disable powermanagment. update comments. remove obsolete files and calls. * hamonized function calls * only copy original file if not already present. even with multiple invocation we want to keep the first original file. Delete autohotspot service in helperscript * update CODEOWNERS * remove changes for autohotspot if not selected * ignore output on service check * fixes for "clear autohotspot configurations" * added test for autohotsppt installation * fix intendation * check for activated wifi device * moved autohotspot installation to separate script moved autohotspot.sh to sampleconfig * fix remove crontab entry * unified: dont remove autohotspot configuration * fix refactored device / ssid check logic on boot or after unblock of wifi the device can give additional errorcodes (-11) this caused incorrectly a hotspot start * fix conf file copy handling on multiple invocation * update docs * refactored duplications * fix for deactivated wifi on startup also check for hard blocked wifi * add --force-hotspot option for easier testing * update script with changes from original source * extend service handling durin installation * some clean up * fix var checks * update docs * update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature to setup a hotspot automatically if no known network is available lives currently in a separate install script (#967). This script is a duplication of the main install script and misses a few recent changes.
To lower the maintanence effort and make the feature generally available, i merged the changes regarding the autohotspot into the main install script.
Additionally i added a config step, so the user can choose if it shall be activated (defaults to NO). Also the default values for the hotspot can now be changed (non interactive mode is covered).
I would also remove this page https://github.com/MiczFlor/RPi-Jukebox-RFID/wiki/Access-Phoniebox-without-Router as it describes the manuell steps covered by this feature and is also outdated.
Some old sample files have been removed.