[PATCH] changing message codes to names

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/158
Reporter	Enrico.Weigelt@….local, metux IT service <weigelt@….de>
Keywords	vote-winnie, vote-slavazanko, committed-master

this patch changes the message type codes passed to functions like message() from integers to names like D_NORMAL or D_ERROR (mostly taken from rhclub tree)

[154feb5]
branch:158_message_codes

Committed master:
[5d15056]

Note

Original attachments:

• msg-codes.001.diff (raw) by on Jan 9, 2009 at 22:27 UTC

[mc-butler]

Changed by mc-butler (@mc-butler) on Jan 9, 2009 at 22:27 UTC

• Attachment msg-codes.001.diff (raw) added
• Id set to 158

This message has 1 attachment(s)

[mc-butler]

Changed by metux (@metux) on Jan 10, 2009 at 14:32 UTC (comment 2)

• Description edited
• Keywords set to review

[mc-butler]

Changed by metux (@metux) on Jan 10, 2009 at 16:34 UTC (comment 3)

• Status changed from new to accepted
• Owner set to metux

[mc-butler]

Changed by winnie (@winnieXY) on Jan 11, 2009 at 12:17 UTC (comment 4)

Patch looks good except one change in src/cmd.c where in line 1226 you delete a char *ptr; can we please move this out of this patch or explain why this is removed there?.

[mc-butler]

Changed by metux (@metux) on Jan 11, 2009 at 16:53 UTC (comment 5)

The removed "char* ptr" in cmd.c is unused.

[mc-butler]

Changed by metux (@metux) on Jan 11, 2009 at 17:23 UTC (comment 6)

• Description edited

[mc-butler]

Changed by winnie (@winnieXY) on Jan 18, 2009 at 16:47 UTC (comment 7)

• Keywords changed from review to review, vote-winnie

Okay.. as the unused pointer is now not longer removed here (but in another ticket) I'll add my vote here.

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 19, 2009 at 12:03 UTC (comment 8)

• Keywords changed from review, vote-winnie to vote-winnie, vote-slavazanko, approved

this patchset based on patches from mc-ru-fork. I see this good patchset and vote to this.

[mc-butler]

Changed by metux (@metux) on Jan 24, 2009 at 3:54 UTC (comment 9)

• Description edited

[mc-butler]

Changed by metux (@metux) on Jan 24, 2009 at 4:01 UTC (comment 10)

• Keywords changed from vote-winnie, vote-slavazanko, approved to vote-winnie, vote-slavazanko, committed-master

[mc-butler]

Changed by winnie (@winnieXY) on Jan 24, 2009 at 12:32 UTC (comment 11)

• Resolution set to fixed
• Status changed from accepted to testing

[mc-butler]

Changed by winnie (@winnieXY) on Jan 24, 2009 at 12:35 UTC (comment 12)

• Status changed from testing to closed