Restore notifications and update checks #161
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| @Override | ||
| protected void onResume() { | ||
| super.onResume(); | ||
| AppUsageNotificationsManager appUsageNotificationsManager = new AppUsageNotificationsManager(this); | ||
| appUsageNotificationsManager.scheduleAppUsageCheck(); | ||
| appUpdateNotificationsManager.checkAndSendUpdateNotification(); | ||
| checkForFlexibleOrImmediateUpdate(); |
There was a problem hiding this comment.
[P1] Guard update notification call on pre‑O devices
AppUpdateNotificationsManager.checkAndSendUpdateNotification() is annotated @RequiresApi(Build.VERSION_CODES.O) and creates a NotificationChannel. The new onResume calls this method every time without checking the SDK level, so on devices running API 23‑25 (the module’s minSdk is 23) the activity will crash on resume with a NoClassDefFoundError. Add an SDK guard before invoking the method or move the version check inside the manager.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
./gradlew test(failed: SDK location not found)https://chatgpt.com/codex/tasks/task_e_68c57e5a5690832da36c0b32fad4c6ae