Refine edge-to-edge handling across screens #259
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| private static void applyInsetsToFloatingButtons(View view, int insetTypes) { | ||
| if (!isVisible(view)) { | ||
| return; | ||
| } | ||
| if (view instanceof ExtendedFloatingActionButton || view instanceof FloatingActionButton) { | ||
| applyInsetsAsMargin(view, insetTypes, false, true); | ||
| return; | ||
| } |
There was a problem hiding this comment.
[P1] Apply FAB inset margins regardless of initial visibility
applyInsetsToFloatingButtons bails out when the view is not VISIBLE, so it never attaches the inset listener to FloatingActionButtons that start as INVISIBLE/GONE and are shown later. Those buttons keep their baseline margins and will overlap navigation gesture areas when they become visible, defeating the goal of this delegate. The inset listener should be attached even when the button is hidden so that margins are updated before it is displayed.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68cdb3bc4e60832d9d5b0065f1facd28