Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to make pyflakes- and manifest-tests run again. #160

Merged
merged 4 commits into from
Nov 2, 2015

Conversation

tcld
Copy link
Contributor

@tcld tcld commented Oct 29, 2015

Problem described here: #158

I used @psi29a 's suggestion regarding the addition to MANIFEST.in.

@tcld
Copy link
Contributor Author

tcld commented Oct 29, 2015

About the tests: The ancient map-stuff should pass once the RNG-changes are merged.

However, the manifest-tests still fail: https://travis-ci.org/Mindwerks/worldengine/jobs/88091783
Does somebody know what do do about it?

@tcld tcld force-pushed the travis_fixes branch 2 times, most recently from b655100 to 008bf56 Compare October 31, 2015 09:27
@tcld
Copy link
Contributor Author

tcld commented Oct 31, 2015

@psi29a: Do you maybe have a hint about what to do to make the manifest-test pass again?

@tcld
Copy link
Contributor Author

tcld commented Nov 1, 2015

I read a bit about MANIFEST.in and how it works and both of the optional tests can now be passed again. I excluded the docs-directory (and thus Biomes.html) in MANIFEST.in - is that the right way to go? If so, this could be merged to make two of the tests run again.

Maybe one of you can have a look at the (tiny) changes, @ftomassetti or @psi29a ?
I also wouldn't mind making the pyflakes-test a non-optional test, since it provides very clear instructions on what to change (and so far it has proven quite useful in my opinion).

@ftomassetti
Copy link
Member

I think we should include the docs directory in MANIFEST.in, so that the user downloading the package have also the docs.

@ftomassetti
Copy link
Member

Aside from including the docs all the rest seems good to me

@tcld
Copy link
Contributor Author

tcld commented Nov 2, 2015

So I should use recursive-include instead? I am not sure if the the test will pass then, but I can try.

@tcld
Copy link
Contributor Author

tcld commented Nov 2, 2015

Ok, it seems to work.

@ftomassetti
Copy link
Member

cool, merging

ftomassetti added a commit that referenced this pull request Nov 2, 2015
Fixes to make pyflakes- and manifest-tests run again.
@ftomassetti ftomassetti merged commit 074da30 into Mindwerks:master Nov 2, 2015
@tcld tcld deleted the travis_fixes branch November 2, 2015 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants