Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heroku Redis Configuration Docs #558

Merged
merged 6 commits into from
Mar 31, 2023
Merged

Heroku Redis Configuration Docs #558

merged 6 commits into from
Mar 31, 2023

Conversation

keshavbiswa
Copy link
Contributor

Closes: #542

@keshavbiswa keshavbiswa changed the title Heroku Redis SSL Docs Heroku Redis Configuration Docs Mar 27, 2023
nateberkopec
nateberkopec requested changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@nateberkopec nateberkopec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link back to the official Heroku doc (mentioned in the original issue)?

A good programmer will look at these instructions and be like "WTF?" but it really is what Heroku is telling people to do, so I want to just make that clear.

nateberkopec
nateberkopec reviewed Mar 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@keshavbiswa keshavbiswa requested review from nateberkopec and removed request for nateberkopec March 30, 2023 06:48
nateberkopec
nateberkopec reviewed Mar 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@keshavbiswa @nateberkopec
Update README.md
35b6686 
Co-authored-by: Nate Berkopec <nate.berkopec@gmail.com>
nateberkopec
nateberkopec requested changes Mar 30, 2023
View reviewed changes
README.md Outdated
end
```

The above code snippet is [Heroku's officially suggested workaround](Look at https://help.heroku.com/HC0F8CUS/redis-connection-issues).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not valid markdown, only the url should be inside the parentheses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@nateberkopec nateberkopec merged commit 8d5c5a0 into MiniProfiler:master Mar 31, 2023
@nateberkopec
Copy link
Collaborator

Thanks @keshavbiswa !

@keshavbiswa keshavbiswa deleted the keshav/add-heroku-ssl-docs branch March 31, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateberkopec nateberkopec Awaiting requested review from nateberkopec

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSL error for Heroku Redis
2 participants
@keshavbiswa @nateberkopec