Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support comments #3

Closed
kowey opened this issue Mar 16, 2013 · 3 comments
Closed

support comments #3

kowey opened this issue Mar 16, 2013 · 3 comments
Assignees

Comments

@kowey
Copy link
Collaborator

kowey commented Mar 16, 2013

Most of the work is there. We should have a DistilledComment type perhaps. The default converter could have an option to include comments or not.

@kowey
Copy link
Collaborator Author

kowey commented Mar 17, 2013

Jasper points out Disqus should have WP comment import (if we never get around to this)

@Minoru
Copy link
Owner

Minoru commented Aug 15, 2016

To close this issue, the following has to be done:

  • figure out how Wordpress exports comments. For Blogger, they're part of the usual dump. Is that so for Wordpress?
  • make Hakyll.Convert.Wordpress.distill accept a Bool indicating if comments are to be exported. If it's True, comments should be put into the post's body, right at the end of it (see Blogger.hs:178-184 for what I mean);
  • update help message (it currently says that we only export Blogger comments);
  • without doubt, some common parts will present themselves. These should be factored out into Hakyll.Convert.Common. (And while we're at it, maybe turn that Bool into something more descriptive.) (Split out into Refactor parts of comments extraction to Hakyll.Convert.Common #13)

@Minoru
Copy link
Owner

Minoru commented Aug 16, 2016

The last item of the plan (the refactoring) was split out into #13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants