Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci changes #528

Merged
merged 1 commit into from
Jul 29, 2024
Merged

ci changes #528

merged 1 commit into from
Jul 29, 2024

Conversation

rubenmarcus
Copy link
Member

@rubenmarcus rubenmarcus commented Jul 29, 2024

PR Type

enhancement, configuration changes


Description

  • Added npm install command before npm ci in both branch-publish.yml and releases.yaml to ensure package-lock.json is in sync.

Changes walkthrough 📝

Relevant files
Configuration changes
branch-publish.yml
Ensure package-lock.json is in sync before CI steps           

.github/workflows/branch-publish.yml

  • Added npm install command before npm ci.
+1/-0     
releases.yaml
Ensure package-lock.json is in sync before CI steps           

.github/workflows/releases.yaml

  • Added npm install command before npm ci.
+1/-0     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@mintbase-codium-pr-agent
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

@mintbase-codium-pr-agent
Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Best practice
Replace npm install with npm ci to ensure consistent dependency resolution in CI environments

Replace npm install with npm ci to ensure that the installation process is
consistent with the package-lock.json and does not modify it. This is crucial for CI
environments to maintain consistent builds across different machines.

.github/workflows/branch-publish.yml [33]

-npm install # Ensure package-lock.json is in sync
+npm ci # Use npm ci to install dependencies ensuring package-lock.json is in sync
 
Suggestion importance[1-10]: 10

Why: The suggestion is correct and addresses a best practice for CI environments by using npm ci instead of npm install, which ensures that the dependencies are installed exactly as specified in the package-lock.json without modifying it. This is crucial for maintaining consistent builds.

10
Use npm ci for consistent and reliable builds in CI/CD pipelines

Use npm ci instead of npm install to ensure that the installation process adheres
strictly to the package-lock.json without updating it, which is more suitable for
automated environments like CI/CD pipelines.

.github/workflows/releases.yaml [31]

-npm install
+npm ci
 
Suggestion importance[1-10]: 10

Why: The suggestion is accurate and improves the reliability of the CI/CD pipeline by using npm ci, which strictly adheres to the package-lock.json and avoids potential issues caused by updating dependencies during the installation process.

10

Copy link
Member

@sainthiago sainthiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@bh2smith
Copy link
Contributor

So our CI wasn't installing before. Is that how the broken PR snuck past?

@bh2smith bh2smith deleted the ci-changes branch July 29, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants