fix(wallet): Encode nonces as base64 on redirect

[tifrel]

PR Type

Bug fix

---

Description

• Fixed an issue where nonce was not encoded as base64 in URL search parameters.
• Updated the nonce parameter encoding in two functions to ensure it is correctly handled during redirects.

---

Changes walkthrough 📝

	Relevant files
Bug fix	mintbase-wallet.ts Encode `nonce` as base64 in URL parameters                              packages/wallet/src/mintbase-wallet.ts Encode nonce as base64 in URL search parameters Updated nonce parameter in two functions +2/-2

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[mintbase-codium-pr-agent]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 Security concerns No specific security concerns detected in the PR code itself, assuming proper validation and sanitization of the nonce value before encoding. However, it's recommended to ensure that all user inputs or external data are validated and sanitized to prevent security vulnerabilities.

⚡ Key issues to review Possible Bug Ensure that the nonce value is properly validated and sanitized before encoding it to base64 to prevent potential security issues such as injection attacks. Possible Bug Ensure that the nonce value is properly validated and sanitized before encoding it to base64 to prevent potential security issues such as injection attacks.

[mintbase-codium-pr-agent]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Add a null check for the nonce variable before encoding it to base64 To ensure that the nonce is properly encoded as a base64 string, it's recommended to check if the nonce is not null or undefined before converting it. This prevents potential runtime errors if nonce is null. packages/wallet/src/mintbase-wallet.ts [220] -newUrl.searchParams.set('nonce', Buffer.from(nonce).toString('base64')); +if (nonce) { + newUrl.searchParams.set('nonce', Buffer.from(nonce).toString('base64')); +} Suggestion importance[1-10]: 9 Why: Adding a null check for the nonce variable before encoding it to base64 is a good practice to prevent potential runtime errors. This suggestion addresses a possible bug and improves the robustness of the code.	9
Robustness	Implement error handling for the base64 encoding process Consider using a try-catch block around the base64 encoding process to handle any exceptions that might occur during the conversion, ensuring the application's stability. packages/wallet/src/mintbase-wallet.ts [220] -newUrl.searchParams.set('nonce', Buffer.from(nonce).toString('base64')); +try { + newUrl.searchParams.set('nonce', Buffer.from(nonce).toString('base64')); +} catch (error) { + console.error('Failed to encode nonce:', error); +} Suggestion importance[1-10]: 8 Why: Using a try-catch block around the base64 encoding process enhances the application's stability by handling any exceptions that might occur. This is a valuable improvement for robustness.	8
Maintainability	Refactor base64 encoding into a reusable utility function To improve code maintainability, consider creating a utility function for encoding values to base64, which can be reused wherever base64 encoding is needed. packages/wallet/src/mintbase-wallet.ts [220] -newUrl.searchParams.set('nonce', Buffer.from(nonce).toString('base64')); +newUrl.searchParams.set('nonce', encodeToBase64(nonce)); +function encodeToBase64(value) { + return Buffer.from(value).toString('base64'); +} + Suggestion importance[1-10]: 7 Why: Creating a utility function for base64 encoding improves code maintainability and reusability. This is a good practice for cleaner and more maintainable code, though not critical.	7
Best practice	Specify the character encoding when converting a string to a Buffer for base64 encoding Ensure consistent encoding by explicitly specifying the character encoding of the input string to Buffer.from, as the default encoding might vary. packages/wallet/src/mintbase-wallet.ts [220] -newUrl.searchParams.set('nonce', Buffer.from(nonce).toString('base64')); +newUrl.searchParams.set('nonce', Buffer.from(nonce, 'utf-8').toString('base64')); Suggestion importance[1-10]: 6 Why: Explicitly specifying the character encoding ensures consistent behavior across different environments. This is a best practice that enhances code reliability, though the impact is relatively minor.	6