Fix windows release directory renaming, regex string escaping and indentation #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally, I’d prefer to have one commit fixing the bug, and one commit fixing the indentation. |
Repository owner
deleted a comment from
coveralls
Mar 28, 2020
Fixed bug caused by the use of `%` on replacement string when calling `string.gsub` (lua >= 5.2). According to [lua-users](http://lua-users.org/wiki/LuaFiveTwo): > ### string.gsub repl > > string.gsub > [[6](http://www.lua.org/manual/5.2/manual.html#pdf-string.gsub)] now > raises an error if the replacement string contains a '%' followed by > a character other than the permitted '%' or digit. In short, the replacement string does not require escaping of *magic characters*.
|
Took the liberty of doing the work myself and force-pushing. Thanks for the patches! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Fixed bug caused by the use of
%on replacement string when callingstring.gsub(lua>=5.2). According to lua-users: (link)In short, the replacement string does not require escaping of magic characters.
2. Function
utils.lua.escape_string_regexrecreated with singlestring.gsubcall.3. Converted a few lines of code with three spaces of indentation to two.