Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2067 #2447

Merged
merged 2 commits into from Jul 3, 2019

Conversation

@isiahmeadows
Copy link
Collaborator

commented Jul 3, 2019

Description

See this comment for some more detail on how I came up with this: #2067 (comment)

The tests were a bit of a challenge as it was easy to screw up the repro by "simplifying" it. It's a very subtle bug that's hard to repro.

Motivation and Context

Fixes #2067
Closes #2431 (that fix was incorrect - my bad @boazblake)

How Has This Been Tested?

Wrote the tests, made sure they failed with the patch commented out, and made sure they then succeeded after the patch.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@project-bot project-bot bot added this to Needs triage in Triage/bugs Jul 3, 2019

@isiahmeadows isiahmeadows merged commit 9e9b89d into MithrilJS:next Jul 3, 2019

Triage/bugs automation moved this from Needs triage to Closed Jul 3, 2019

@isiahmeadows isiahmeadows deleted the isiahmeadows:fix-update branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.