Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FindScotch module respect QUIET #264

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

jcortial-safran
Copy link
Contributor

CMAKE_REQUIRED_QUIET must be set to make check_function_exists and check_c_source_runs quiet as well.

CMAKE_REAUIRED_QUIET must be set to make `check_function_exists`
and `check_c_source_runs` quiet as well.
@jcortial-safran
Copy link
Contributor Author

Thanks @Algiane ! Would it be possible to merge the PR ?

Also, do you plan to make a release at some point ?

@Algiane Algiane merged commit fe5ce20 into MmgTools:master Apr 25, 2024
1 check passed
@Algiane
Copy link
Member

Algiane commented Apr 25, 2024

Hi @jcortial-safran ,

We are planning a release for November at the latest. It will not bring new features but will improve:

  • the robustness of Mmg3d in presence of non-manifold geometries (thanks to the debugging work of @coprigent for the MICORCARD project);
  • the developer documentation (thanks to the contribution of @mpotse).

Best,

@prj-
Copy link
Contributor

prj- commented Apr 25, 2024

Please keep develop in sync.

@jcortial-safran
Copy link
Contributor Author

Hi @jcortial-safran ,

We are planning a release for November at the latest. It will not bring new features but will improve:

  • the robustness of Mmg3d in presence of non-manifold geometries (thanks to the debugging work of @coprigent for the MICORCARD project);
  • the developer documentation (thanks to the contribution of @mpotse).

Best,

Sounds good !

Would it be possible to make a patch release (such as version 5.7.3) in the meantime ?

@Algiane Algiane added kind: enhancement enhancement to an existing feature part: cmake cmake part labels Apr 25, 2024
@jcortial-safran jcortial-safran deleted the cmake-find-scotch-quiet branch April 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement enhancement to an existing feature part: cmake cmake part
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants