Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/required vertices preservation #273

Merged
merged 3 commits into from
May 21, 2024

Conversation

Algiane
Copy link
Member

@Algiane Algiane commented May 21, 2024

The xreg option (regularization of the position of boundary vertices) was not preserving required vertices. The current PR:

  1. adds a continuous intgration test that test the preservation of an input vertex (in cmake/testing/code/req-vert-3d.c)
  2. adds the check of required vertices in the xreq option.

@Algiane Algiane self-assigned this May 21, 2024
@Algiane Algiane added kind: bug error or fault part: mmg3d mmg3d specific part: mesh adaptation mesh adaptation mode specificity labels May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 51.26%. Comparing base (96eab63) to head (662302f).
Report is 4 commits behind head on develop.

Files Patch % Lines
cmake/testing/code/req-vert-3d.c 0.00% 12 Missing ⚠️
cmake/testing/code/req-vert-s.c 0.00% 12 Missing ⚠️
src/mmg3d/analys_3d.c 0.00% 0 Missing and 2 partials ⚠️
src/mmgs/analys_s.c 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #273      +/-   ##
===========================================
+ Coverage    50.47%   51.26%   +0.78%     
===========================================
  Files          174      176       +2     
  Lines        47158    49124    +1966     
  Branches     10255    11449    +1194     
===========================================
+ Hits         23802    25181    +1379     
- Misses       15633    15934     +301     
- Partials      7723     8009     +286     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane force-pushed the feature/requiredVertices-preservation branch from ea4a796 to 662302f Compare May 21, 2024 14:01
@Algiane Algiane merged commit f09cee8 into develop May 21, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug error or fault part: mesh adaptation mesh adaptation mode specificity part: mmg3d mmg3d specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant