-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1425 output fieldname of missing recommended field notice even if there is no column #1511
feat: 1425 output fieldname of missing recommended field notice even if there is no column #1511
Conversation
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
1 similar comment
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
✅ Rule acceptance tests passed. |
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
✅ Rule acceptance tests passed. |
core/src/main/java/org/mobilitydata/gtfsvalidator/parsing/RowParser.java
Outdated
Show resolved
Hide resolved
…ed_field-notice-even-if-there-is-no-column
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was nicely done! 🚀
Thank you!!! I'm happy with my contribution!
…On Wed, Jun 21, 2023 at 10:50 AM David Gamez ***@***.***> wrote:
***@***.**** approved this pull request.
It was nicely done! 🚀
—
Reply to this email directly, view it on GitHub
<#1511 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMFN63ZSSJELYA5BKUZNODXMMC2LANCNFSM6AAAAAAZNYXAPQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Summary:
Closes #1425
User can see the fieldName header displayed for feed_contact_email and feed_contact_url as shown in the screenshot.
Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything