Skip to content

Conversation

KashEight
Copy link
Contributor

Overview

  • Use strict-equal (===, !==) instead of lossy-equal (==, !=)
  • Add eslint rule 'eqeqeq'
  • Add TODO comments to lines needed to refactor
    • e.g.) comparison between objects, null and undefined

Testing

  • Only eslint testing
    • Some errors (I cannot replace with strict-equal) are suppressed using eslint-disable-next-line

Comment

Basically, I checked the type of variables and whether there is at least a primitive such as "str", 42 in comparison or not.
I add null-check or undefined-check in some comparisons not to break.

Funny things: after adding rule 'eqeqeq':

$ yarn run lint:eslint
✖ 240 problems (200 errors, 40 warnings)
  39 errors and 0 warnings potentially fixable with the `--fix` option.

chore(eslint): add rule 'eqeqeq'

Signed-off-by: kash / Hytus <kash@hytus.net>
Signed-off-by: kash / Hytus <kash@hytus.net>
@Luffyyy Luffyyy merged commit 7c2ed69 into ModWorkshop:main Oct 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants