Skip to content

Conversation

wuayee
Copy link
Contributor

@wuayee wuayee commented Jun 7, 2025

🔗 相关问题 / Related Issue

Issue 链接 / Issue Link: #227

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

应用重命名后,可能导致task_new表同一应用的template_id不同。这会导致数据错乱,即同一应用可能出现不同template_id的场景。该变更修复上述问题,将template_id与应用名解绑。
After the application is renamed, the template_id of the same application in the task_new table may be different. This will cause data confusion, that is, the same application may have different template_ids. This change fixes the above problem and unbinds the template_id from the application name.

📋 主要变更 / Brief Changelog

  1. 修改task_new的数据创建,其template_id直接由appVersion传入,即与应用绑定。而不是查询task_new的name再做处理。
    Modify the data creation of task_new, and its template_id is directly passed in from appVersion, that is, it is bound to the application. Instead of querying the name of task_new and then processing it.

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. 创建应用 / Create app
  2. 修改应用名,并重新编排 / Modify the application name and rearrange it
  3. 此时查看task_new表,出现的同一应用不同task,其template_id相同 / Check the task_new table now, and you will see different tasks for the same application with the same template_id
  4. 发布后,发布时task_new创建的数据的template_id,也与1、2步骤创建的数据的template_id相同 / After publishing, the template_id of the data created by task_new during publishing is also the same as the template_id of the data created in steps 1 and 2

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过:mvn -B clean package -Dmaven.test.skip=true / Basic checks pass
  • 单元测试通过:mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes


审查者注意事项 / Reviewer Notes:

@wuayee wuayee added this to the 1.1.0 milestone Jun 7, 2025
@wuayee wuayee requested review from CodeCasterX, Msquittto and a team June 7, 2025 07:14
@wuayee wuayee self-assigned this Jun 7, 2025
@wuayee wuayee added type: bug A general bug in: builder Issues in app-builder modules labels Jun 7, 2025
@wuayee wuayee added this to Nova Jun 7, 2025
@wuayee wuayee force-pushed the appbuilder-bugfix-lift-name-and-app-suite-id branch from 85d597a to 4a54fe2 Compare June 7, 2025 08:02
@CodeCasterX CodeCasterX changed the title [appBuilder] Disentangle app_suite_id and name [app-builder] Disentangle app_suite_id and name Jun 9, 2025
@CodeCasterX CodeCasterX linked an issue Jun 9, 2025 that may be closed by this pull request
4 tasks
@CodeCasterX
Copy link
Member

action 运行失败是计划内的,近期在安排排查修复中,目前不影响功能。

@CodeCasterX CodeCasterX merged commit 681a559 into ModelEngine-Group:develop Jun 9, 2025
0 of 2 checks passed
@github-project-automation github-project-automation bot moved this to Done in Nova Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: builder Issues in app-builder modules type: bug A general bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

应用重命名后,可能导致task_new表同一应用的template_id不同
3 participants