Fix plotting and printing of SurvLIME for the coxph model (#73)

* Fix issue #72 * Bump version for development and update NEWS
ModelOriented · Mar 24, 2023 · 4292856 · 4292856
1 parent 76993e0
commit 4292856
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: survex
 Title: Explainable Machine Learning in Survival Analysis
-Version: 1.0.0
+Version: 1.0.0.9000
 Authors@R: 
     c(
         person("Mikołaj", "Spytek", email = "mikolajspytek@gmail.com", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-7111-2286")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# survex (development)
+
+* Fix not being able to plot or print SurvLIME results for the cph model sometimes. ([#72](https://github.com/ModelOriented/survex/issues/72))
+
 # survex 1.0.0
 
 * *breaking change:* refactored the structure of `model_performance_survival` object - calculated metrics are now in a `$result` list.

diff --git a/R/plot_surv_lime.R b/R/plot_surv_lime.R
@@ -39,7 +39,7 @@ plot.surv_lime <- function(x,
     if (!type %in% c("coefficients", "local_importance"))
         stop("Type should be one of `coefficients`, `local_importance`")
 
-    local_importance <- as.numeric(x$result * x$variable_values)
+    local_importance <- as.numeric(x$result) * as.numeric(x$variable_values)
     df <- data.frame(variable_names = names(x$variable_values),
                      variable_values = as.numeric(x$variable_values),
                      beta = as.numeric(x$result),

diff --git a/R/print.R b/R/print.R
@@ -33,7 +33,7 @@ print.surv_feature_importance <- function(x, ...) {
 print.surv_lime <- function(x, ...) {
     res <- x$result
 
-    print_result <- rbind(beta = res, `X` = x$variable_values, `local importance (X*beta)` = res * x$variable_values)
+    print_result <- rbind(beta = res, `X` = x$variable_values, `local importance (X*beta)` = res * as.numeric(x$variable_values))
     cat("SurvLIME for observation:\n\n")
     print.data.frame(x$variable_values, row.names = FALSE)
     cat("\n")