This repository was archived by the owner on Jul 13, 2020. It is now read-only.
add support for environments with both window and global #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers will always have `window` and possibly `global` with node-webkit. Node will never have `window` but always have `global`.
stevenvachon
changed the title
guybedford
added a commit
that referenced
this pull request
Sep 13, 2014
add support for environments with both window and global
|
Note we actually needed d76ec80 for web worker support as well. That is quite complicated - it is quite bad for node webkit to be breaking existing global detection conventions, but happy to support it. |
|
How better could they have done it? They literally merged Node and a browser, so we end up with both to support most libraries. |
|
Actually we should use that! |
|
Maybe you could check out google/traceur-compiler#1340 as it pertains to this. I ran into issues making the changes myself. |
|
I can't guarantee the time input either right now unfortunately. Perhaps in the mean time an alternative would be to precompile the Traceur modules from ES6 into System.register. Then you only need to focus on Traceur runtime support. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers will always have
windowand possiblyglobalwith node-webkit (or similar).Node will never have
windowbut always haveglobal.