Adds support for custom equality checks on unwrap #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vb
reviewed
Jun 15, 2023
| const demoFacet = createFacet({ initialValue: value }) | ||
|
|
||
| // Dummy equality check that always returns its not equal | ||
| const check = jest.fn().mockReturnValue(false) |
There was a problem hiding this comment.
Should we also test for equal cases?
There was a problem hiding this comment.
The goal of the test was to be able to validate that the check itself was being used, as the actual comparison (or usage of the check) is done within the createFacet function.
vb
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple extension of the existing
useFacetUnwrapAPI, allowing passing an optional extra argument to perform custom equality checks.As its an optional argument, this is not breaking the current API contract.