Skip to content

Fix PHP8.2 'RowEvent' calling 'array_sum' that might be false. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 10, 2023
Merged

Fix PHP8.2 'RowEvent' calling 'array_sum' that might be false. #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d9ecfd1
Fix php8.1 Deprecated
Moln Jan 10, 2023
6c6ab9d
Fix Deprecated with php8.1
Moln Jan 10, 2023
8482ab0
Update README.md
Moln Jan 10, 2023
b650a87
Fix error of php8.2
Moln Jan 10, 2023
f7c2787
Add phpcs, and fix CS.
Moln Jan 10, 2023
c130257
Update badge
Moln Jan 10, 2023
5deb953
Fix action checking
Moln Jan 10, 2023
0f82245
Fix action checking
Moln Jan 10, 2023
90da1d9
Fix action checking
Moln Jan 10, 2023
5151956
Fix action checking
Moln Jan 10, 2023
6548ce6
Fix PHP8.2 'RowEvent' calling 'array_sum' that might be `false`.
Moln Jan 10, 2023
f4db308
Merge branch 'master' of github.com:Moln/php-mysql-replication into d…
Moln Jan 10, 2023
12c85c2
Fix CI
Moln Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ jobs:
env:
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
composer require "php-coveralls/php-coveralls:^2" --dev -W
ls ./vendor/bin
composer require "php-coveralls/php-coveralls:^2" --dev -q -W
./vendor/bin/phpunit --coverage-clover build/logs/clover.xml
./vendor/bin/php-coveralls -v
3 changes: 2 additions & 1 deletion src/MySQLReplication/Event/RowEvent/RowEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,8 @@ protected function getDatetime(): ?string
}

$date = DateTime::createFromFormat('YmdHis', $value)->format('Y-m-d H:i:s');
if (array_sum(DateTime::getLastErrors()) > 0) {
$dateLastErrors = DateTime::getLastErrors();
if ($dateLastErrors && array_sum($dateLastErrors) > 0) {
return null;
}

Expand Down