Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpriteFont implementation does not handle left-side overhang of the first character in a line #1355

Closed
kg opened this issue Feb 12, 2013 · 2 comments

Comments

@kg
Copy link
Contributor

kg commented Feb 12, 2013

When the first character in a line of text overhangs to the left, XNA's SpriteFont implementation offsets the text to the right so that the string as a whole does not overflow its measured rectangle. MonoGame currently doesn't do this, so fonts with this kind of overhang will exceed their measured bounds (and get cut off if being drawn at the edges of a screen/render target).

I have a preliminary implementation of this here:
kg@40f155c

@tomspilman
Copy link
Member

Seems like a plausible bug there. That code is pretty much the original from Bill Reiss's SilverSprite code base... there have been a few fixes there, but i'm sure there are things that have been missed.

We need to setup some sort of test to verify it, but I say cherry pick that revision into a new branch and submit a pull request.

kg added a commit to kg/MonoGame that referenced this issue Apr 29, 2013
kg added a commit to kg/MonoGame that referenced this issue Apr 29, 2013
kg added a commit to kg/MonoGame that referenced this issue Apr 29, 2013
KonajuGames added a commit that referenced this issue May 1, 2013
Implement left-side overhang compensation for SpriteFont (#1355)
@danzel
Copy link
Contributor

danzel commented Apr 18, 2014

#1606 was merged so this is fixed. Close me.

alxwest pushed a commit to alxwest/MonoGame that referenced this issue May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants