Added GPU instancing for DirectX #2047
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Change method names to match XNA naming
|
@mgbot test |
|
This is great... thanks for contributing it!
I think that isn't really required to make it work. I suspect you missed the |
| /// <param name="primitiveCount">The number of primitives to render from the index buffer.</param> | ||
| /// <param name="instanceCount">The number of instance to render.</param> | ||
| /// <remarks>Note that minVertexIndex and numVertices are unused in MonoGame and will be ignored. The name of methos depicts the purpose of methos better then XNA's</remarks> | ||
| public void DrawIndexedInstancedPrimitives(PrimitiveType primitiveType, int baseVertex, int minVertexIndex, int numVertices, int startIndex, int primitiveCount, int instanceCount) |
There was a problem hiding this comment.
DrawIndexedInstancedPrimitives is not an XNA method... why have this instead of just DrawInstancedPrimitives?
|
|
Test PASSed. |
Hum... looking at @KonajuGames implementation, i like how he internally it manages the vertex buffer bindings. It is more generalized. @ossaltu - What are your thoughts? |
|
True, @KonajuGames implementation is more general, but it does not conflict with my changes. I guess, it is ok to have several ways to use instancing api of monogame: simple one, I have implemented and more general/complex implemented by @KonajuGames which is based on VertexBufferBinding object and which can be used in other rendering scenarios.
I've added DrawInstancedPrimitives for XNA compatibility. DrawIndexedInstancedPrimitives is depicting the purpose of method better, because the method uses index buffer. DrawInstancedPrimitives feels like it does not use index buffer, while in XNA it actually it does. Latter DrawInstancedPrimitives override can be added which actually will not use index buffer. Hope it makes sense :) |
|
When can one expect to see this in the developer installer or the develop branch? Or am I missing something? |
|
So this is heavily conflicted now and my issues were not answered or addressed. Thanks for trying to contribute, I apologize we didn't get it merged. |
Works on HiDef profile on DirectX projects. Has a difference with XNA framework interface: instead of doing this:
_device.SetVertexBuffers(
new VertexBufferBinding(vertexBuffer, 0, 0),
new VertexBufferBinding(instanceBuffer, 0, 1)
);
you should do it like this:
_device.SetVertexBuffer(vertexBuffer);
_device.SetInstanceBuffer(instanceBuffer);
Other API parts of instancing is same as in XNA.