Fix texture ValidateParams exception with DXT1/3/5 decompression on Linux #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't make it a permanent change in Protogame. It is only your use case of Mesa in a headless GPU-less environment that does not support DXT (due to S3TC patent fears). Anyone playing a game on Linux will not be using Mesa and will have DXT support. |
|
Merging. Thanks @hach-que |
|
I ran into this same bug on a console platform where we were using the original PC XNBs decompressed. Thanks @hach-que ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on Linux without DXT decompression support (such as the Mesa OpenGL software renderer), the code path for decompressing DXT textures on load is hit. This code currently has a bug where
levelDataSizeInBytesis passed through to theSetDatamethod, butlevelDataSizeInBytesis not updated after DXT decompression, so the validation which occurs inside Texture2D to check that the element count is correct fails.@KonajuGames has informed me this code path is likely going away soon, so I'll also be future proofing Protogame to turn off DXT compression for textures in the content pipeline when targeting Linux (since it's not supported everywhere).