Support unicode in window title under DesktopGL #6335
Conversation
MonoGame.Framework/SDL/SDL2.cs
Outdated
| @@ -431,7 +431,7 @@ public static void SetFullscreen(IntPtr window, int flags) | |||
| public static d_sdl_setwindowsize SetSize = FuncLoader.LoadFunction<d_sdl_setwindowsize>(NativeLibrary, "SDL_SetWindowSize"); | |||
|
|
|||
| [UnmanagedFunctionPointer(CallingConvention.Cdecl)] | |||
| public delegate void d_sdl_setwindowtitle(IntPtr window, string title); | |||
| public delegate void d_sdl_setwindowtitle(IntPtr window, ref byte value); | |||
There was a problem hiding this comment.
You should create a helper function which accepts string in SDL2.cs and not modify any code in SDLGameWindow.
Also is in allowed instead of ref?
There was a problem hiding this comment.
Updated! We can't use in because it's a C# 7.2 feature.
There was a problem hiding this comment.
@Jjagg @cra0zy Not sure if you're aware, but there's also directional attributes which can be used to optimise marshaling. So even though you can't use in, you can still use InAttribute. I know it works with extern, but I'm not sure when using delegates as I haven't tried that before. But it should work the same way I'd assume. e.g.
[UnmanagedFunctionPointer(CallingConvention.Cdecl)]
private delegate void d_sdl_setwindowtitle(IntPtr window, [In] byte[] value);SDL_SetWindowTitle(handle, Encoding.UTF8.GetBytes(title));The code is fine though. This is not a nit-pick, just more of an FYI. Hope it's useful!
There was a problem hiding this comment.
Yeah, we should probably do a run through for all delegates and add In or Out where applicable (it does work the same). I didn't add it because we don't use them anywhere.
There was a problem hiding this comment.
Directional attributes are optional. You apply them to method parameters when you want to
alter the default behavior of the marshaler. If you omit directional attributes from a method
parameter, the marshaler determines the directional flow based on the type of the
parameter (value or reference) and its modifiers, if any.
https://msdn.microsoft.com/en-us/library/77e6taeh(v=vs.85).aspx
tomspilman
changed the title
|
Merging! |
This issue was reported on the forums: http://community.monogame.net/t/encoding-problem/10700
Encodes window title with UTF-8 so SDL handles it right.
https://wiki.libsdl.org/SDL_SetWindowTitle
Before:
After:
