Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing files in MonoGameContentProcessors.csproj #706

Merged
merged 3 commits into from Aug 24, 2012

Conversation

Aranda
Copy link
Contributor

@Aranda Aranda commented Aug 24, 2012

No description provided.

@Aranda
Copy link
Contributor Author

Aranda commented Aug 24, 2012

@tomspilman @espes

So I fixed the build of MonoGameContentProcessors and 2MGFX, but to do so I removed csproj file references to DXEffectObject.fxparser.cs. I thought this was only to be removed from the runtime. Perhaps I'm getting mixed up with different effect parsing functionality?

@tomspilman
Copy link
Member

Hard to say off the top of my head... espes moved a bunch of stuff around there. Let me investigate what went where and i'll get back to you.

@tomspilman
Copy link
Member

Ok... after examining the code changes there and looking at you're changes here it seems this pull request is good and fixes the MonoGameContentProcessors assembly to build again.

Gonna merge it.

tomspilman added a commit that referenced this pull request Aug 24, 2012
Fix missing files in MonoGameContentProcessors.csproj
@tomspilman tomspilman merged commit acc4ff1 into MonoGame:develop3d Aug 24, 2012
@tomspilman
Copy link
Member

@Aranda - If you try to run 2MGFX to generate a GL shader does it work for you? I get an exception...

Unable to find an entry point named 'MOJOSHADER_parse' in DLL 'libmojoshader_32.dll'.

Are you seeing the same thing?

  • Tom

@Aranda
Copy link
Contributor Author

Aranda commented Aug 25, 2012

@tomspilman yes I get the same error, although initially I couldn't even get this far. I had to change MojoShader.cs to reference the correct DLL file name:

const string mojoshader_dll = "libmojoshader_32.dll";

@tomspilman
Copy link
Member

Yea... I fixed that as well. Just waiting to hear from espes now to figure out what changed with that assembly.

@espes
Copy link
Contributor

espes commented Aug 25, 2012

Mojoshader was updated and some function signatures were changed. An updated the 32bit windows dll is in ThirdParty/Libs.

It seems I just messed up the filename in the bindings. I remember I had a hack in there to select the 32bit/64bit windows dll instead of hardcoding it at one point and meant to investigate.

Though I may also have messed up the windows build settings. I'll have a look tomorrow :/

@david-lively
Copy link
Contributor

Any news on this?

tomspilman added a commit that referenced this pull request Nov 23, 2012
Fixes #706, MGMaterialProcessor not using MGEffectProcessor.
alxwest pushed a commit to alxwest/MonoGame that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants