Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented PubSub #47

Merged
merged 62 commits into from
Jul 1, 2019
Merged

Implemented PubSub #47

merged 62 commits into from
Jul 1, 2019

Conversation

ChronosXYZ
Copy link
Contributor

No description provided.

ChronosXYZ and others added 30 commits June 20, 2019 15:04
@ChronosXYZ
fix: Fix for GetConfig args
949457b
@ChronosXYZ
[WIP] Add basic support of PubSub (not work yet)
8d2d895
@ChronosXYZ
fix: Fix issue when found hosts aren't connected to each others (in c…
60193dc 
…onsequence, the messages did not go)
@JackBekket
flags
cca13dd
@JackBekket
start fixing
7977a19
@JackBekket
go.mod & version fix
e9e2d6f
@JackBekket
logic fix
94bf4b9
@JackBekket
clean
8bdf2c2
@JackBekket
clean
28bc932
@JackBekket
small fix
d9c59dc
@JackBekket
TODO
db525e0
@JackBekket
clean
80e4c1f
@JackBekket
new handler
67c714a
@JackBekket
few new handlers
dd7fe94
@JackBekket
p2mobile read/write messages to topics
410c7a7
@JackBekket
first build
2eacd63
@JackBekket
bug fixes
a44a866
@JackBekket
stream functions removed
aedc393
@JackBekket
some todos
0f9547d
@JackBekket
new topic func
eb20ee8
@JackBekket
Merge pull request #34 from MoonSHRD/refactor/p2mobile
3051ffe 
Refactor/p2mobile
@JackBekket
Merge pull request #43 from MoonSHRD/refactor/pubsub
2135014 
Refactor/pubsub
@ChronosXYZ
refactor: Align tabulation of code
6651a01
@ChronosXYZ
fix: Add possibility to connect many nodes and get incoming messages …
49f696d 
…in background
@ChronosXYZ
cleanup: Remove mDNS binary
f95a11c
@ChronosXYZ
feat: Implemented basic protocol of message exchange
d2eb5f2
@ChronosXYZ
fix: Change type of networkTopics to Set (that there were no duplicat…
e739eef 
…ion of topics)
@ChronosXYZ
Add binary to gitignore
1d55639
@ChronosXYZ
docs: Add basic documentation of out protocol
bbda3dd
@ChronosXYZ
feat: Add periodically requesting for topics
f5c7312
JackBekket
JackBekket requested changes Jun 30, 2019
View reviewed changes
Copy link
Member

@JackBekket JackBekket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job's done!

However we still need to change README, and provide new docs for new implemented functional

@JackBekket JackBekket mentioned this pull request Jun 30, 2019
Closed
@MoonSHRD MoonSHRD deleted a comment from todo bot Jul 1, 2019
@MoonSHRD MoonSHRD deleted a comment from todo bot Jul 1, 2019
@MoonSHRD MoonSHRD deleted a comment from todo bot Jul 1, 2019
@MoonSHRD MoonSHRD deleted a comment from todo bot Jul 1, 2019
@MoonSHRD MoonSHRD deleted a comment from todo bot Jul 1, 2019
@ChronosXYZ
Copy link
Contributor Author

Now the job is exactly done.

@todo
Copy link

todo bot commented Jul 1, 2019

`

p2chat/CONTRIBUTING.md

Lines 5 to 10 in 8df1784

`// TODO`
## Commit message format
### Message Structure

This comment was generated by todo based on a TODO comment in 8df1784 in #47. cc @MoonSHRD.

@todo
Copy link

todo bot commented Jul 1, 2019

Update Readme & checkout and replace better comments

p2chat/cmd/main.go

Lines 32 to 37 in 8df1784

// TODO: Update Readme & checkout and replace better comments
*/

This comment was generated by todo based on a TODO comment in 8df1784 in #47. cc @MoonSHRD.

@MoonSHRD MoonSHRD deleted a comment from todo bot Jul 1, 2019
@MoonSHRD MoonSHRD deleted a comment from todo bot Jul 1, 2019
@MoonSHRD MoonSHRD deleted a comment from todo bot Jul 1, 2019
@MoonSHRD MoonSHRD deleted a comment from todo bot Jul 1, 2019
@MoonSHRD MoonSHRD deleted a comment from todo bot Jul 1, 2019
@JackBekket JackBekket merged commit fe4dfe4 into master Jul 1, 2019
This was referenced Jul 1, 2019
Closed
Open
@ChronosXYZ ChronosXYZ deleted the feat/pubsub branch July 6, 2019 09:21
ChronosXYZ pushed a commit that referenced this pull request Jul 8, 2019
@JackBekket
Merge pull request #47 from MoonSHRD/feat/pubsub
d987ebd 
Implemented PubSub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBekket JackBekket JackBekket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChronosXYZ @JackBekket @burik666