-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Harman Air to Installer #32
Comments
By the current MSDKI way, the application has fixed versions for each particular SDK which determines from its configuration file. This also decides which version of Flex and AIR SDK should download. Remaining by the existing way, I can imagine a new entry of Flex SDK with Harman AIR, which shall download a Flex SDK and Harman AIR SDK and uncompress them in a way so the AIR overlays correctly on Flex SDK. I guess the For any existing Flex SDK (with or without AIR), user can go following the instruction of overlaying Harman AIR and do this by themselves only. I'm not in a favor of cover many test cases with different way of doing on this regard. |
Maybe we should go with simpler way. Just add entry which downloads Harman Air for Flex Developers and put message for the user - that he has to download manually Flex SDK binaries and unpack it to folder with downloaded Harman Air. However I need to first check if Flex SDK binaries + Harman Air is enough to work. |
This could be a simpler procedure for us, however, this may not support the idea behind creating MSDKI - to install fully working SDK to the user's system. On a separate note, we may need to ensure that we won't get into any legal trouble if we distribute Harman AIR through MSDKI (if the MSDKI nature is meant to be a distribution) if we already not did. |
Before we place link in our MSDKI I will ask them. |
We had some more discussion for this here: Moonshine-IDE/Moonshine-IDE#773 The plan is to download and extract a fresh copy of the Flex SDK. Then Harman AIR should be downloaded and extracted into new SDK directory. Then we will need to use an Ant script to update some references in frameworks/air-config.xml. Remove
Note that the second reference can be removed entirely, since we already have a path-element for We may also need to update some other configuration files similar to what the Flex SDK Installer script is doing currently. For example update the AIR version in |
I'm starts looking into this. |
- Initial detections for the Flex/Harman - Changes in Moonshine source on initial detections - Copyright load/show changes for the Flex/Harman (#32)
Updates:
(The multi-copyright information for Flex/Harman currently loads from https://moonshine-ide.com/downloads/msdki/apache-flex-harman-sdk-installer-config.xml, when in case of Flex/Adobe loads from their remote site - http://www.apache.org/dist/flex/4.16.1/binaries/apache-flex-sdk-installer-config.xml. Having the Flex/Harman hosted remotely also fits the current design of parsing and triggering copyright URLs, in MSDKI. The other way could be having the xml bundled in the package, but this will cost additional logic in MSDKI to understand a local source). |
I see @rat-moonshine got the license for Harman AIR from this page: https://airsdk.harman.com/download We'll need to be careful that we are displaying this properly for users. I'm not sure if we need to show the privacy policy and other links as well. |
While working on the downloading scripts in Ant file for the Harman AIR SDK, it starts to terminates every time. After some investigation it found that accepting the copyright information (at Haman website) generates an id-based download URL, i.e. If one try to access the above link, s/he could see something like this:
While trying to download through Ant by not generating a valid download-id, download starts failing each time. It appears the id is browser-session-based. The possible solution could be (either any):
|
@rat-moonshine So do we have a way of moving forward with that ? |
I didn't have a chance so far I shall plan to re-visit that shortly. |
…ul download/extraction of Apache Flex SDK (#32)
…arman_sdk # Resolved Conflicts: # InstallerSharedCore/src/actionScripts/interfaces/IHelperMoonshineBridge.as # InstallerSharedCore/src/actionScripts/managers/DetectionManager.as # InstallerSharedCore/src/actionScripts/utils/HelperUtils.as # InstallerSharedCore/src/actionScripts/valueObjects/ComponentTypes.as # InstallerSharedCore/src/components/renderers/ComponentRenderer.mxml # InstallerSharedCore/src/helperResources/data/moonshineHelperConfig.xml (#32)
I have committed first working version of Apache Flex + Harman AIR download/extract/merge process, currently testing only on macOS. There still some UI tuning requires but the download and merge process is mostly working. However, I'm seeing strange problem while trying to run Flex Desktop sample project:
I tried to test by manually downloading Apache Flex binary and Harman AIR SDK and merge the latter over former, that also result the above error. One can download a Flex binary from here (macOS): https://apachemirror.wuchna.com/flex/4.16.1/binaries/apache-flex-sdk-4.16.1-bin.tar.gz. Untar it somewhere. I confirm the air-config.xml file has necessary changes by itself, but I'm not familiar with this new error. (Untar command if it's handy: |
During a manual download/test by @JoelProminic the merged SDK seems to worked for him. The difference he chose is to run I shall re-visit these command and tests again. |
For quick reference, here are my commands.
|
In practice, this didn't helped me either. I continue to see the error along with a new different warning, on macOS:
I even tried to remove any extended attributes if causing the warnings, but that didn't helped too. However, building a pure ActionScript project (.as) seems to be successful (with warning):
|
Updates now merged onto |
I have fixed the symlink issues in installing SDK. SDK is now installed properly on Bamboo build system. I need to writeup a detail documentation on this soon. |
Great! I have successfully installed Harman Air with new nightly. One issue left to close this one I believe. |
We were facing an (application)startup error on macOS packaged with the Harman SDK/Flex for some time:
After investigation it turned out the problem is not related with overlaying-ways of Harman SDK on Apache Flex, but unzipping-ways of Harman SDK. There are some symlink files exists in the
In any way, The broken symlink files in After some discussion @JoelProminic pointed this might be a known issue to Ant. We also decided to manually delete the broken symlink files and re-create them. @JoelProminic suggested with some good ways to get a list of symlink files (to a directory) and an working way to re-create the list of symlink files in Ant: Get a list of symlink files to test_valid directory
An working module to re-create list of symlink files in Ant
While the Ant solution should be pretty good for direct-Ant handling, @piotrzarzycki21 this might worthy for you in case of Git Actions Ant run. Unfortunately, this didn't worked-out using original SDK Installer source. MSDKI, or the original SDK Installer source uses an ActionScript implementation of real Ant API. This is to facilitate Ant running in the system where Ant SDK is not installed (if I'm right). The ActionScript implementation is pretty old, and supports only very basic tags from Ant SDK, here's a complete list of the tags - https://github.com/Moonshine-IDE/Moonshine-SDK-Installer/tree/master/flex-utilities/flex-installer/ant_on_air/src/org/apache/flex/ant/tags. The implementation thrown error while executing tags like So I chose to go with shell-execution way. It does same thing - delete the existing/broken symlink file, re-create new symlinks. This took me quite some time to properly execute the symlink creation process, though. This because of the relative path-way the symlink requires to be created that should work across the machines. Initially I faced troubles when a symlink created by the path of a system, failed to work on another system, i.e. symlink path fixed on Bamboo system does not work on my system. I think the working-directory also an important part in this relative path process. Anyway, finally I able to create proper relative symlink files that works across the system. I have tested installing the SDK on Bamboo build system where symlinks get fixed as part of the MSDKI installation process, packaged application using the SDK that installed and run properly in different system. The only thing is that the listings are fixed since running a |
I did a quick test today, and the symlinks look good. I was able to Build & Run Moonshine-IDE with the latest Flex SDK (Harman AIR) install. @rat-moonshine mentioned there were a few more things to fix, and I would like to do a final Windows test before the release as well to make sure there were no unexpected changes. |
I have completed my remaining fixes as form of: I'm good to close this issue hereafter. |
I have just tested downloading Harman Air and everything seems to be good! Thanks! |
Added scripts to update SDK label text. |
@Aszusz if your setup is ready please download nightly and test that on Windows. Make sure that latest build has this fix. |
I have tested on Mac OSX Big Sur and I see correct value with newest build. |
Once we fix that splash screen issues, this one should be closed and we are ready to release. |
This should be fixed now with latest builds. I have placed license file recently on Windows build-system. |
I confirm the splash screen disappeared from both Moonshine IDE and Moonshine SDK Installer. Since everything is looking good now I'm closing this issue. |
We should investigate what we need to do in order to add Harman Air to our installer.
Current path to install Harman Air for Flex developer is following:
Options:
User has Flex + old Adobe Air on disk
Because it would be a lot of downloading if we first download Flex + Adobe Air and next overlay with Harman Air, maybe user should be forced to point folder with Flex which he have to have on disk.
User has only Flex binaries - no Adobe Air SDK
The other options is to download pure binaries Apache Flex binaries without any dependencies and overlay it with Harman Air - I'm not sure if it would work.
The text was updated successfully, but these errors were encountered: