Meshgen module #99
Merged
Meshgen module #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including documentation and examples
ConduitDan
reviewed
Feb 25, 2022
morpho5/docs/meshgen.md
Outdated
| ## Domain | ||
| [tagdomain]: # (domain) | ||
|
|
||
| The `Domain` class is used to conveniently build a |
There was a problem hiding this comment.
Is the last part of the sentence missing?
There was a problem hiding this comment.
Great catch there! Will fix later...
|
|
||
| Create a domain corresponding to the unit disk: | ||
|
|
||
| var c = CircularDomain([0,0], 1) |
There was a problem hiding this comment.
is the origin argument restricted to 2D?
There was a problem hiding this comment.
(looking at the code I don't think it is but it might be nice to mention?)
There was a problem hiding this comment.
So currently n-D meshes have to be in n-D. I should note this...
Update meshgen to improve documentation, improve benchmarking and add in a unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meshgen module added, including documentation and examples.