Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub Issue Comments) An empty image placeholder is displayed in the OP when hiding +1 comments #84

Closed
darkred opened this issue May 23, 2019 · 5 comments

Comments

@darkred
Copy link
Collaborator

darkred commented May 23, 2019

STR
With Chrome 74/Firefox 67 and only Tampermonkey beta 4.9.5941 and 'GitHub Issue Comments' v1.3.7 :

Could you please take a look, @Mottie ?


As a sidenote, the +1 Comments doesn't show up as active/available filter in the above issue page when enabling the global "Toggle items" filter, even though it has content.

@darkred darkred changed the title GitHub Issue Comments - An empty image placeholder is displayed in the OP when hiding +1 comments (GitHub Issue Comments) An empty image placeholder is displayed in the OP when hiding +1 comments May 23, 2019
@Mottie
Copy link
Owner

Mottie commented May 24, 2019

Hi @darkred!

It looks like GitHub moved their emoji assets. As for the +1 comments showing up... it seems intermittent. Sometimes I see it inactive and other times it's active. I'll check into it when I have time this weekend.

@Mottie Mottie closed this as completed in ceb3dbd May 24, 2019
@Mottie
Copy link
Owner

Mottie commented May 24, 2019

Oops

@Mottie Mottie reopened this May 24, 2019
@Mottie
Copy link
Owner

Mottie commented Jun 22, 2019

The +1 entry seems to consistently show up now. I didn't change anything, but now I can't reproduce the problem.

@Mottie Mottie closed this as completed Jun 22, 2019
@darkred
Copy link
Collaborator Author

darkred commented Jun 22, 2019

Yes, it shows up consistently, I confirm.

Unofortunately the other issue still occurs:

As a sidenote, the +1 Comments doesn't show up as active/available filter in the above issue page when enabling the global "Toggle items" filter, even though it has content.

@darkred
Copy link
Collaborator Author

darkred commented Mar 1, 2020

Fixed via a commit for #105 .

@darkred darkred closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants