Revert #2672, fixing #2788 and part of #2804, but bringing back #2605 #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…temporarily until refixed.
Cervator
added
Topic: Architecture
This was referenced Mar 5, 2017
|
Hooray Jenkins reported success with all tests good! |
Closed
This was referenced Mar 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sort of interesting one, tho the PR is just for documentation purposes and I'll re-open #2605 for a re-fix, then merge this in preparation for Alpha 7.
In short: @portokaliu in #2605 reported an issue where an entity went funny and ended up showing a mesh of what the host player is holding, rendered at 0, 0, 0 for client players. @Tropid found a fix for it via PR #2672 that filtered out some stuff preventing the entity quirk from rendering the bogus object. However, that in turn filtered too much causing held torches to not give up light and gifted goodie boxes in Core to not work.
We need to improve the fix in #2672 or find an alternative that doesn't cause undesired side effects. Maybe this is indicative of a networking strategy we can improve somehow? In the meantime this simply reverts the changes to
FirstPersonClientSystemfrom #2672Pinging @flo and @iojw for some networking interest and thanking @nihal111 for finding the connection between the issues :-) Also hoping @portokaliu and @Tropid can weigh in on improving the fix.
Image of the issue being re-introduced by this PR since I think it is funny: