-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code highlighting #243
base: master
Are you sure you want to change the base?
Code highlighting #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screenshot you shared in #211 indeed looks better.
Looking at the code I think this makes sense, but I'm not a front-end person, so I cannot be certain. Also, I'd like to test this out locally before merging. I'll try to find time to do that this weekend, not sure I will though, so apologies as it might take another week before I get to merge this.
@@ -22,6 +22,12 @@ export default class Blog extends React.Component { | |||
const { date } = postNode.fields; | |||
return ( | |||
<Layout title={post.title}> | |||
<style jsx>{` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sonar complains about this and I'm not familiar with this syntax. Can you tell me what this does / is supposed to do?
Tests out fine, but I'm still curious about that |
Quality Gate passedIssues Measures |
Hi, sorry for the late reply. The style jsx just makes every html element of the class "gatsby-highlight" bigger. I couldn't find another way of doing it from the settings. I think something somewhere is overriding the font size so i had to add the style jsx thing. |
So we're using styled jsx here, I see. If this doesn't work on your side either, I think we can make ESLint ignore the line via |
Fixes #211