Self-Host Fonts #12351
Merged
Self-Host Fonts #12351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdivincenzo
added
run visual regression tests
and removed
run visual regression tests
labels
mmmavis
approved these changes
May 18, 2024
There was a problem hiding this comment.
Great work! Thanks @robdivincenzo ! I didn't realize this many files would be affected until I saw your PR 😅
As a follow-up discussion, I wonder if we want to move fonts related bits out of the SCSS/SASS ecosystem to improve our build time. It's very unlikely that we wanna modify those font files (we probably shouldn't anyway). If we can convert the font .scss files into .css and just include them as is, it will shorten the watch/build cycle during development. SCSS does take very looooong to compile and that is that one thing I dislike about SCSS. I will file a new ticket to discuss about this.
|
@robdivincenzo Awesome. Thank you! |
|
➤ Simon Acosta Torres commented: PR has already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will introduce self-hosted fonts rather than relying on google's font delivery service.
Link to sample test page: https://foundation-s-tp1-671-12-isi5mm.herokuapp.com
Related PRs/issues: TP1-671 #12348
To Test
Nunito SansandZilla Slabshould load from static files without regression.Caveatfont should also load from static files without regression (see names of on the love letters)Changashould also load from static files without regression (see headline for example)┆Issue is synchronized with this Jira Story