Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove block_count check from blog and article models #12726

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

robdivincenzo
Copy link
Collaborator

@robdivincenzo robdivincenzo commented Aug 20, 2024

Description

The typeform block was removed in #12712. This PR removes typeform block_count checks from blog and article models that are preventing publishing of those pages.

Link to sample test page: https://foundation-s-tp1-1063-1-ugwx9r.herokuapp.com/cms/pages/12/
Related PRs/issues: #12725 TP1-1063

To Test

  1. Checkout main locally and log in to the cms dashboard
  2. Try to create a new blog page
  3. Notice the typeform key error
  4. Check out this branch tp1-1063-12725-typeform-block-counts locally
  5. Try to create a new blog page
  6. Notice there is no longer a key error

You may also test on the review app with credentials: admin / n*z6RAsBpp7Aez4Z

┆Issue is synchronized with this Jira Story

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-1063-1-ugwx9r August 20, 2024 19:18 Inactive
Copy link
Collaborator

@ramram-mf ramram-mf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Rob

@robdivincenzo robdivincenzo merged commit f185c0f into main Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants