Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pillow dependency #1897

Merged
merged 1 commit into from
Dec 11, 2018
Merged

remove pillow dependency #1897

merged 1 commit into from
Dec 11, 2018

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Oct 3, 2018

While wagtail relies on pillow, we don't explicitly use it ourselves, and so we don't need it in our our pipfile

Copy link
Contributor

@patjouk patjouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @cadecairos do you also want to take a look?

@Pomax Pomax requested a review from cadecairos October 9, 2018 19:17
@cadecairos
Copy link

@Pomax can you rebase and fix the conflict so we can merge this?

@Pomax
Copy link
Contributor Author

Pomax commented Nov 22, 2018

I can't really get the pip lock file to only update the pillow part and the master hash, a new venv ends up bumping some things automatically.

@Pomax
Copy link
Contributor Author

Pomax commented Nov 22, 2018

Aparently, no rebasing/respinning I can do on my windows machine seems to fix this piplock issue.

@Pomax
Copy link
Contributor Author

Pomax commented Dec 11, 2018

Redid the PR on current master.

@Pomax
Copy link
Contributor Author

Pomax commented Dec 11, 2018

@cadecairos just reset you for review, just to make sure we had eyes on it before merge =)

@Pomax Pomax removed the request for review from patjouk December 11, 2018 17:10
@Pomax Pomax merged commit e958fe7 into master Dec 11, 2018
@Pomax Pomax deleted the no-pillow branch December 11, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants