Buyer's Guide og tags & main nav share icons #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmavis
commented
Oct 18, 2018
mmmavis
changed the title
|
Yay looks great! Copy link doesn't work on my iPhone but that is an issue on the live site and also on the category page so we can try to sort that out later. |
kristinashu
approved these changes
Oct 18, 2018
|
Let's actually go ahead and leave the removal of the login prevention when we merge this since we want this to be unlocked today anyway. |
alanmoo
reviewed
Oct 18, 2018
| @@ -30,7 +30,7 @@ def get_average_creepiness(product): | |||
|
|
|||
| # Login required so we can continue to develop this and merge into master without the public seeing it. | |||
| # Remove this when we're ready to launch. | |||
| @login_required | |||
| # @login_required | |||
There was a problem hiding this comment.
Suggested change
| # @login_required | |
| @login_required |
alanmoo
reviewed
Oct 18, 2018
| @@ -41,7 +41,7 @@ def buyersguide_home(request): | |||
| }) | |||
|
|
|||
|
|
|||
| @login_required | |||
| # @login_required | |||
There was a problem hiding this comment.
Suggested change
| # @login_required | |
| @login_required |
alanmoo
reviewed
Oct 18, 2018
| @@ -53,7 +53,7 @@ def category_view(request, categoryname): | |||
| }) | |||
|
|
|||
|
|
|||
| @login_required | |||
| # @login_required | |||
There was a problem hiding this comment.
Suggested change
| # @login_required | |
| @login_required |
alanmoo
reviewed
Oct 18, 2018
| @@ -64,7 +64,7 @@ def product_view(request, productname): | |||
| }) | |||
|
|
|||
|
|
|||
| @login_required | |||
| # @login_required | |||
There was a problem hiding this comment.
Suggested change
| # @login_required | |
| @login_required |
alanmoo
previously requested changes
Oct 18, 2018
alanmoo
approved these changes
Oct 18, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1899
https://foundation-mofostaging-pr-1926.herokuapp.com/privacynotincluded/
Only covers the following
Not covered in this PR
❗️ Remember to revert changes in
network-api/networkapi/buyersguide/views.pybefore merging