Social shares on Buyer's Guide product pages #1975
Conversation
|
Amazing! You got it to pull the product name and it's creepiness! |
| @@ -159,6 +160,18 @@ export default class CreepVote extends React.Component { | |||
| * @returns {jsx} What users see when they have voted on this product. | |||
| */ | |||
| renderDidVote(){ | |||
| let numGroups = 5; | |||
There was a problem hiding this comment.
Pomax landed a PR that has the creepiness groups as a constant- can we leverage that so we're not replicating it here?
There was a problem hiding this comment.
@alanmoo can you point me where that variable is? I can't find it in creep-vote.jsx
There was a problem hiding this comment.
https://github.com/mozilla/foundation.mozilla.org/pull/1967/files (creepiness-labels.js)
| let userVoteGroup = Math.floor(this.state.creepiness/(100/NUM_GROUPS)); | ||
| let creepType; | ||
|
|
||
| if (userVoteGroup < Math.floor(NUM_GROUPS/2)) { // lower half groups |
There was a problem hiding this comment.
Can't this be something like
creepType = CREEPINESS_LABELS[userVoteGroup]?
There was a problem hiding this comment.
Nah, it's not 1-1. We only have 3 versions of keyword we wanna use in social share.
There was a problem hiding this comment.
version depending on a users vote: "CREEPY" (first two bars), "NOT REALLY CREEPY" (middle), "NOT CREEPY" (last two bars)]
There was a problem hiding this comment.
We can do what Pomax did to make things consistent.
There was a problem hiding this comment.
k I'll update - @kristinashu should I make the label all caps in social share? e.g., SOMEWHAT CREEPY, A LITTLE CREEPY etc
There was a problem hiding this comment.
lol yeah uppercase is great, thank you!
There was a problem hiding this comment.
Unless that's more complicated, then lowercase is cool too!
|
Done! @alanmoo |
Related to #1899
Covers
Based on specs in #1899 (comment) but we might want to update the pre-populated text a bit though... /cc @kristinashu