Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote now button enabled on-click #7626

Closed
wants to merge 29 commits into from
Closed

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Oct 15, 2021

Closes #7574

Link to sample test page:

Checklist

Changes in Models:

TheoChevalier and others added 29 commits September 23, 2021 10:57
* Blog category title localization

* CI

* Fixing CI harder

* review feedback
…t variable (#7482)

* make sure locale fallback for get_entries gets assigned to the correct variable

* Update network-api/networkapi/wagtailpages/pagemodels/index.py

Co-authored-by: Daniel Miranda <manieldiranda@gmail.com>
Added streamfields and icons
Fixed
Co-authored-by: Pomax <pomax@nihongoresources.com>
* Synchronize inlinePanel fields with translations

* Not empty anymore

Co-authored-by: Pomax <pomax@nihongoresources.com>
* create a database copying script

* Update local_development.md

* Update copy-db.js

* Update copy-db.js

* Update copy-db.js

* Update copy-db.js

* Update copy-db.js
Co-authored-by: Daniel Miranda <manieldiranda@gmail.com>
* fix POST handling of localized PNI products

* just needs tests now

* Update buyersguide_item.html

* test update - products were not getting saved

* .
* Add common reusable link blocks

* BE: Mozfest Spaces Cards

Related issue: #7428

* Add link property

* Organize imports

* Add title to SpaceCardListBlock

* Use StreamBlock for page field

* Remove unused imports

* [7427] Spaces cards FE (#7444)

* Spaces cards start

* Spaces grid spacing

* Update spaces_cards heading'

* Add in backend django jijna vars

* Revert mozfest-base

* Revert package-lock file to normal

* Convert section heading to h2 for a11y

* Rename template to work with BE, adjust variables to work with BE

* Update migrations

* Rename template

* Update card href

* Update type styles, grid and flexbox width

* Only add Spaces Cards to Mozfest-related pages

* Update migrations

* Use common link components

* Fix template href

* Fix grid col count with singup block

Co-authored-by: boggs <hello@boggs.xyz>
…es (#7567)

Co-authored-by: Théo Chevalier <theo.chevalier11@gmail.com>
Co-authored-by: Pomax <pomax@nihongoresources.com>
* sort menu and settings submenu alphabetically

* Update wagtail_hooks.py
Co-authored-by: Daniel Miranda <manieldiranda@gmail.com>
@mofodevops mofodevops temporarily deployed to foundation-s-creepomete-y2rn0l October 15, 2021 18:36 Inactive
@danielfmiranda danielfmiranda changed the base branch from main to pni-q3-2021 October 15, 2021 18:56
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

Copy link

@sabrinang sabrinang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reviewing this page https://foundation-s-creepomete-y2rn0l.mofostaging.net/en/privacynotincluded/far-fire-together-office-control-impact-section-result/

The button is enabled already when the page loads and clicking on the bar doesn't move the slider. Let me know if I am reviewing the right page.

@danielfmiranda
Copy link
Collaborator Author

Closing as duplicate of #7627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PNI] Creep-o-Meter bug
10 participants