Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Press Globe + Shift + Space to enter fullscreen mode #40

Closed
qkdxorjs1002 opened this issue Sep 22, 2023 · 8 comments Β· Fixed by #43
Closed

✨ Press Globe + Shift + Space to enter fullscreen mode #40

qkdxorjs1002 opened this issue Sep 22, 2023 · 8 comments Β· Fixed by #43
Assignees
Labels

Comments

@qkdxorjs1002
Copy link

Feature Request Description

It would be more useful to using hotkey like, Press Globe + Shift + Space to enter fullscreen mode. πŸ‘

Screenshots

No response

Additional Context

No response

@MrKai77
Copy link
Owner

MrKai77 commented Sep 22, 2023

Great idea!

While the keybind you suggested seems ideal, the only concern I have about this is that Globe and Shift are both options to become trigger keys, so it might not work well in some cases where the user's trigger key is the Shift key.
As a general rule of thumb, all keybinds so far in this project have been modifier key (a.k.a. trigger key) + non-modifier key (ex. A, B, C etc.).

However, I can see using the Shift key for other keybinds as well. I wonder if there may be any other keybinds that could work well? Maybe Trigger key + F? But that could also be a little confusing to new users, because the maximize keybind is already tied to the Space key. Maybe it's best to have the Shift key removed as an option to become a trigger key, so that it can become a modifier for existing keybinds? Do you have any thoughts about this?

@qkdxorjs1002
Copy link
Author

qkdxorjs1002 commented Sep 22, 2023

Nice! I agree with you. It seems could be clearly and easily press with only two finger no crossed. 😊

@MrKai77
Copy link
Owner

MrKai77 commented Sep 22, 2023

Got it! I'll implement it with Trigger Key + F to toggle fullscreen :)
This will probably be done within the next few days (probably tomorrow!)

@MrKai77 MrKai77 self-assigned this Sep 22, 2023
MrKai77 added a commit that referenced this issue Sep 22, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Sep 22, 2023

Alright, here's a working build, with changes from this issue and from #39! While it works well, I believe the Trigger key + Shift + Space keybind that you originally recommended may work better, so I think I will change it to that, so let's keep this issue open for now :)!

Loop.zip

@MrKai77
Copy link
Owner

MrKai77 commented Sep 24, 2023

I successfully changed the keybind to Trigger key + Shift + Space!
Here's a working build: Loop.zip
Let me know if you notice any bugs!

@MrKai77
Copy link
Owner

MrKai77 commented Sep 24, 2023

Sorry, it seems like I missed a bug πŸ›
Here's the latest build: Loop.zip

MrKai77 added a commit that referenced this issue Sep 26, 2023
@MrKai77 MrKai77 mentioned this issue Oct 30, 2023
2 tasks
@chrislafay
Copy link

In Mac, it's possible to "full screen" an application and have multiple apps "side-by-side" in full-screen mode. This allows for multiple desktops each with multiple screens attached to each.

I searched throughout the changelogs for "full screen" and wasn't able to find anything. I don't think this is supported yet, but am curious if it is on the horizon.

@MrKai77
Copy link
Owner

MrKai77 commented Jun 19, 2024

Hey @chrislafay! It seems like Loop hasn't had any tickets related to the fullscreen-split functionality, I'd appreciate it if you could open a new ticket about that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants