Skip to content

upgrade react/react-router-dom version #278

@MuYunyun

Description

@MuYunyun

React 18 it's coming, let's update it.

  • Upgrade React from v17 to v18
  • Upgrade react-router-dom from v4 to v6
    • Upgrade react-router-dom from v4 to v5.1
    • Upgrade react-router-dom from v5.1 to v6

Upgrade React

It'll cause some unkown error using hydrateRoot here:

image

So still using hydrate temporarily.

import { hydrate } from 'react-dom'
import { renderToString } from 'react-dom/server';
// import { hydrateRoot } from 'react-dom/client'
import '@babel/polyfill'
import { ifDev, ifPrerender } from 'crd-client-utils'
import RouterRoot from './Router'

if (ifDev) {
  // dev render
  document.getElementById('root').innerHTML = renderToString(<RouterRoot />)
  hydrate(
    <RouterRoot />,
    document.getElementById('root'),
  )
  // hydrateRoot(
  //   document.getElementById('root'),
  //   <RouterRoot />,
  // )
} else if (ifPrerender) {
  // prerender
  document.getElementById('root').innerHTML = renderToString(<RouterRoot />)
} else {
  // prod render:
  // It'll cause some [unkown error](https://github.com/MuYunyun/create-react-doc/issues/278) using hydrateRoot here.
  // So still using hydrate temporarily.
  hydrate(
    <RouterRoot />,
    document.getElementById('root'),
  )
  // hydrateRoot(
  //   document.getElementById('root'),
  //   <RouterRoot />,
  // )
}

Upgrade react-router-dom

Metadata

Metadata

Assignees

Labels

wontfixThis will not be worked on

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions