Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Use same expand icon in nav menu #9233

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

danielchalmers
Copy link
Contributor

@danielchalmers danielchalmers commented Jun 21, 2024

Description

For consistency

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Before (take note of the mix of two different icons)

image

After (all use the same default icon set)

image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added docs Related to docs PR: needs review labels Jun 21, 2024
@danielchalmers
Copy link
Contributor Author

image

Don't know how I didn't notice this before

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.87%. Comparing base (28bc599) to head (623529c).
Report is 294 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9233      +/-   ##
==========================================
+ Coverage   89.82%   90.87%   +1.04%     
==========================================
  Files         412      401      -11     
  Lines       11878    12521     +643     
  Branches     2364     2433      +69     
==========================================
+ Hits        10670    11379     +709     
+ Misses        681      604      -77     
- Partials      527      538      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 22, 2024

@ScarletKuro ScarletKuro requested a review from henon June 22, 2024 12:42
@dennisrahmen
Copy link
Contributor

Wouldn't it be the other icon?
Since all other components use it as the default icon for opening/expanding?

@henon
Copy link
Collaborator

henon commented Jun 22, 2024

I am also rooting for the chevron

@danielchalmers
Copy link
Contributor Author

@dennisrahmen @henon So do we change the default to ExpandMore?

/// <summary>
/// If set, overrides the default expand icon.
/// </summary>
[Parameter]
[Category(CategoryTypes.NavMenu.Appearance)]
public string ExpandIcon { get; set; } = Icons.Material.Filled.ArrowDropDown;

@henon
Copy link
Collaborator

henon commented Jun 23, 2024

No, changing a default is nasty business. Better would be to make sure the nav groups are all set to chevron in our docs

@danielchalmers
Copy link
Contributor Author

@henon done

@danielchalmers danielchalmers changed the title Docs: Use default expand icon in nav menu Docs: Use same expand icon in nav menu Jun 23, 2024
@henon henon merged commit 0d87963 into MudBlazor:dev Jun 24, 2024
4 checks passed
@henon
Copy link
Collaborator

henon commented Jun 24, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants