-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Use same expand icon in nav menu #9233
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9233 +/- ##
==========================================
+ Coverage 89.82% 90.87% +1.04%
==========================================
Files 412 401 -11
Lines 11878 12521 +643
Branches 2364 2433 +69
==========================================
+ Hits 10670 11379 +709
+ Misses 681 604 -77
- Partials 527 538 +11 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Wouldn't it be the other icon? |
I am also rooting for the chevron |
@dennisrahmen @henon So do we change the default to MudBlazor/src/MudBlazor/Components/NavMenu/MudNavGroup.razor.cs Lines 119 to 124 in 9b365aa
|
No, changing a default is nasty business. Better would be to make sure the nav groups are all set to chevron in our docs |
@henon done |
Thanks |
Description
For consistency
How Has This Been Tested?
visually
Type of Changes
Before (take note of the mix of two different icons)
After (all use the same default icon set)
Checklist
dev
).