Fix: Crash & MSP Downloads #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
demonnic
approved these changes
Jun 5, 2023
|
Thank you for the fix! |
vadi2
pushed a commit
to vadi2/Mudlet
that referenced
this pull request
Dec 24, 2023
<!-- Keep the title short & concise so anyone non-technical can
understand it,
the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
Mudlet was not downloading sounds nested in a subdirectory from the
Internet and playing them with Mud Sound Protocol (MSP). Also, a
segfault was entered into the development stream with
Mudlet#6654, which this resolves.
#### Motivation for adding to Mudlet
Issue Mudlet#6790
Issue Mudlet#6851
#### Other info (issues closed, discussion etc)
Resolved an issue where Mudlet was not downloading sounds from the
Internet and playing them with Mud Sound Protocol (MSP).
**Steps to reproduce the issue from Mudlet#6790:**
- Logon to aldebaran-mud.de 2000 as the guest character.
- Create a [sound
trigger](https://wiki.mudlet.org/w/Manual:Supported_Protocols#MSP_for_Lua)
for MSP.
- Issue these commands: yes;;s;;e;;e;;e;;s;;strike gong.
If you are on the PTB, your Mudlet client may crash. If you are on
4.17.2, you'll just likely not hear the sound as intended, although it
will have downloaded. And if you are using this PR, hopefully everything
works great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Mudlet was not downloading sounds nested in a subdirectory from the Internet and playing them with Mud Sound Protocol (MSP). Also, a segfault was entered into the development stream with #6654, which this resolves.
Motivation for adding to Mudlet
Issue #6790
Issue #6851
Other info (issues closed, discussion etc)
Resolved an issue where Mudlet was not downloading sounds from the Internet and playing them with Mud Sound Protocol (MSP).
Steps to reproduce the issue from #6790:
If you are on the PTB, your Mudlet client may crash. If you are on 4.17.2, you'll just likely not hear the sound as intended, although it will have downloaded. And if you are using this PR, hopefully everything works great!