Ethereum Alarm Clock Integration #1343

e00dan · 2018-03-19T22:33:35Z

Description

Integrate with Ethereum Alarm Clock to provide a way to schedule transaction.

Changes

Add scheduling to main tab

Steps to Test

Go to Send Ether & Tokens
Toggle 'Send Later'
Fill required fields
Press 'Schedule transaction'
Sign it

Screenshots

tayvano · 2018-04-05T14:52:45Z

UI Improvements (Ideas - To be discussed further)

Change the word "Scheduled" next to the toggle to "Send Later"
Change "Time" and "Block" radio buttons to read "Minutes" and "Blocks". Remove (min) from label above.
Change placeholder text in Window field so that it's 100% readable. Perhaps use an example?
Default to a 10 minute time period
Add copy underneath "Scheduled Transaction Settings": "This allows you to schedule a transaction for sending at a later time. Due to unforeseen circumstances (like the state of the network), we cannot 100% guarantee that your transaction is sent in the time period you specify." We will add a link to a knowledge base article when that article is ready.
Add explanations and warnings for Window, Time Bounty, and Require Deposit that explain what they are and potential downsides if they do something wrong in hover-overs. Provide recommendations on what the user should choose.
~~Gas Price / Gas Limit should match existing UI to stay consistent.~~
- (Will O): As for gas UI, that might be difficult for a few reasons. One is estimation doesn’t work for the future, and the other problem is that all of our reusable components are built to modify the current transaction. It’ll be a heavy amount of code modification to get the slider working for scheduled transactions. I think we could punt on that to get this working without further expanding the scope of this already large PR.
Move "Powered by ChonoLogic" to the right side of the box. Reduce size by ~30%

* Scheduling: Basic date and time widget * Linting fixes * Moved the datetime field to new tab * Fixed push errors * Added missing specs * Undid unintentional UI change * Fixed some failing tests * Ignore datetime parameter when checking if a transaction is full * Added a date selector widget and renamed ScheduleTimestamp to ScheduleDate * Marked componentDidMount * Initialized Pikaday * Revert "Initialized Pikaday" This reverts commit 4e5bf5b. * Revert "Marked componentDidMount" This reverts commit 85d5219. * Revert "Added a date selector widget and renamed ScheduleTimestamp to ScheduleDate" This reverts commit aaad0ac. * Converted the date picker into a datetime picker * Added decent styling to the datetimepicker * Added validation to the datetime picker * Fixed prepush errors for scheduling timestamp * Adjusted validation logic scheduling timestamp

* [FEATURE] Scheduling: Timezone selector * Removed zombie files

* Implemented time/block switcher fuctionality

* Reordered, renamed and centered scheduling elements * Added the toggle button styling * Class -> ClassName

HenryNguyen5 · 2018-04-09T19:59:11Z

common/sagas/transaction/network/gas.ts

+          value: gasLimit
+        };
+
+        const scheduling: SetSchedulingToggleAction['payload'] = yield select(getSchedulingToggle);


This could be in its own selector isSchedulingEnabled

HenryNguyen5 · 2018-04-09T20:00:28Z

common/selectors/schedule/helpers.ts

+
+const calculateWindowStart = (
+  scheduleType: string | null,
+  scheduleTimestamp: any,


any type here

HenryNguyen5 · 2018-04-09T20:01:57Z

common/selectors/schedule/transaction.ts

+  const depositValid = isValidScheduleDeposit(state);
+  const timeBountyValid = isValidCurrentTimeBounty(state);
+
+  return (


it would be nice if large conditionals like these were commented in groups for maintainability

…ation

…ypto into feature/eac-integration

dternyak · 2018-04-12T04:45:27Z

Thanks a lot for the merge - we're getting really close here!

There are a few style issues that could be improved before this gets merged into develop:

Date & Time and Timezone fields have values cut-off. If we decrease the Window field size and expand the others, there should be enough room for all elements. Stacking the Windows and Blocks toggles would further increase the room for the Date & Time and Timezone fields.

The Timezone selection has a large amount of options, making it difficult to select a relevant timezone. I'm not sure of an optimal solution, but we could potentially just shorten the number of options to the total possible timezones (e.g. GMT-1, GMT-2, ...).
(Nitpick) Tooltips should be activated on hover over of the question icon, not labels.

wbobeirne

Sorry for the delay on reviewing, I'm going to dismiss be previous request changes. Found a few other things in here, but other than the NewTabLink, I think everything looks good here. Ran a test on Kovan and it worked great.

wbobeirne · 2018-04-12T17:20:49Z

common/actions/transaction/actionTypes/fields.ts

+interface InputTimeBountyIntentAction {
+  type: TypeKeys.TIME_BOUNTY_INPUT_INTENT;
+  payload: string;
+}


Leftover unused actions

wbobeirne · 2018-04-12T17:20:57Z

common/actions/transaction/constants.ts

@@ -30,6 +30,8 @@ export enum TypeKeys {
  GAS_LIMIT_INPUT = 'GAS_LIMIT_INPUT',
  GAS_PRICE_INPUT = 'GAS_PRICE_INPUT',
  GAS_PRICE_INPUT_INTENT = 'GAS_PRICE_INPUT_INTENT',
+  TIME_BOUNTY_INPUT = 'TIME_BOUNTY_INPUT',
+  TIME_BOUNTY_INPUT_INTENT = 'TIME_BOUNTY_INPUT_INTENT',


Leftover unused actions

wbobeirne · 2018-04-12T17:43:58Z

common/components/ExtendedNotifications/TransactionSucceeded.tsx

+  let scheduleDetailsBtn: React.ReactElement<string> | undefined;
+  if (scheduling) {
+    scheduleDetailsBtn = (
+      <a href={getTXDetailsCheckURL(txHash)} className="btn btn-xs">


This should use the NewTabLink component.

wbobeirne · 2018-04-12T17:45:37Z

common/containers/Tabs/ScheduleTransaction/components/ScheduleFields.scss

+
+  &-field-title {
+    position: relative;
+    white-space: nowrap;


I think this may have caused some kind of issue with the tooltips:

Fixed in: 5624221

wbobeirne · 2018-04-12T17:57:54Z

...ransaction/components/Fields/WindowStart/WindowStartFieldFactory/WindowStartFieldFactory.tsx

+    if (windowStart) {
+      this.props.setCurrentWindowStart(windowStart);
+    } else {
+      this.props.setCurrentWindowStart(latestBlock);


We're going to need to kick off a fetch for latest block somewhere. Right now I think it only gets fetched when you change nodes. Looks like the default value is '???'.

Alternatively we could just start with an empty field.

I've removed the default value and we'll start with an empty field.

Issues addressed

wbobeirne

All of my comments have been addressed, this is. a 👍 from me. Looking forward to mainnet!

HenryNguyen5 · 2018-04-14T02:10:12Z

common/components/TXMetaDataPanel/components/AdvancedGas.tsx

+
+    return (
+      <div>
+        {timeBounty && timeBounty.value && timeBounty.value.toString()} + {gasPriceWei} *{' '}


No need for the .toString methods here, they'll get converted to a string regardless

Seems they don't get converted implicitly. Removing the .toString methods results in an error:

Objects are not valid as a React child (found: object with keys {negative, words, length, red}). If you meant to render a collection of children, use an array instead```

HenryNguyen5 · 2018-04-14T02:11:30Z

common/components/TXMetaDataPanel/components/FeeSummary.tsx

@@ -69,17 +86,50 @@ class FeeSummary extends React.Component<Props> {
    );

    return (
-      <div className="FeeSummary">
+      <div className={`FeeSummary ${scheduling && 'SchedulingFeeSummary'}`}>


This boolean will add false to the classname if scheduling is false

e00dan force-pushed the feature/eac-integration branch 3 times, most recently from 5eb33da to 42b6b91 Compare March 29, 2018 17:11

e00dan force-pushed the feature/eac-integration branch from aa4efeb to 0b600d0 Compare April 5, 2018 17:15

e00dan and others added 25 commits April 6, 2018 15:55

[FEATURE] Initial EAC integration.

f2afd78

Title and explanation

577ab52

[FEATURE] Move the Schedule Payment to the main tab.

eb19dd9

[FEATURE] TimeBounty slider.

d2b3d9c

[FEATURE] Move to main menu.

e3884fc

[FEATURE] Redirection to the DApp for details.

9a70d77

[FEATURE] Move scheduling to main tab.

2294046

[FEATURE] Timezone selector

53f5122

* [FEATURE] Scheduling: Timezone selector * Removed zombie files

[FEATURE] Reimplement Time Bounty.

49fa54b

[FEATURE] Time/block selector

09b1062

[FEATURE] Add Window Size field.

68cc318

[FEATURE] Time/block switch functionality

7097fd3

* Implemented time/block switcher fuctionality

[FEATURE] Add Schedule Gas Price field.

97896b3

[FEATURE] Scheduling toggle

7428b12

[FEATURE] Add basic styling and network check.

7267f35

[FEATURE] Add Schedule Gas Limit field

62f528f

[FEATURE] "Scheduled" button styling

02ba3ea

* Reordered, renamed and centered scheduling elements * Added the toggle button styling * Class -> ClassName

[FEATURE] Add Deposit field

353eeb5

[FEATURE] Move scheduling code into one directory

42af363

[FIX] Scheduling responsiveness

c2f1d00

[FIX] Datetime picker not working on md screens

7795aac

[FEATURE] Timestamp Scheduling basic functionality

a79b1d7

[FIX] Fix data serialization.

cc84e5f

[FEATURE] Timezone inclusion

1a7fe08

HenryNguyen5 reviewed Apr 9, 2018

View reviewed changes

josipbagaric and others added 7 commits April 10, 2018 07:29

[FIX] Timestamp scheduling - Validation match

5ec73a3

[FIX] EAC integration touchups

fdcb19f

[FIX] Code review fixes

5d1dd04

[FIX] Window Size type

61400fb

[FIX] Type fixes.

db8363d

Merge remote-tracking branch 'origin/develop' into feature/eac-integr…

499d6e5

…ation

Merge branch 'feature/eac-integration' of github.com:chronologic/MyCr…

08cb556

…ypto into feature/eac-integration

[FIX] Make tooltips only show on icons + resposiveness fixes

83676c8

wbobeirne reviewed Apr 12, 2018

View reviewed changes

josipbagaric and others added 5 commits April 13, 2018 06:00

[FIX] Break tooltips into more lines

5624221

[FIX] Remove unnecessary code.

08c0c6a

Merge develop.

66738d9

[FIX] Remove unnecessary code.

fa12f5a

[FIX] Remove unnecessary types declaration.

d5a4304

wbobeirne previously approved these changes Apr 13, 2018

View reviewed changes

dternyak changed the title ~~[FEATURE] Ethereum Alarm Clock integration~~ Ethereum Alarm Clock Integration Apr 13, 2018

HenryNguyen5 reviewed Apr 14, 2018

View reviewed changes

[FIX] Fee class names

8342b61

josipbagaric dismissed wbobeirne’s stale review via 8342b61 April 14, 2018 07:19

Merge branch 'develop' into feature/eac-integration

d178d7b

dternyak approved these changes Apr 14, 2018

View reviewed changes

dternyak merged commit 985ea0f into MyCryptoHQ:develop Apr 14, 2018

e00dan deleted the feature/eac-integration branch April 16, 2018 04:39

kosecki123 mentioned this pull request Nov 16, 2018

Add Scheduled Tx Submission MetaMask/metamask-extension#729

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ethereum Alarm Clock Integration #1343

Ethereum Alarm Clock Integration #1343

e00dan commented Mar 19, 2018 •

edited

Loading

tayvano commented Apr 5, 2018 •

edited

Loading

HenryNguyen5 Apr 9, 2018

HenryNguyen5 Apr 9, 2018

HenryNguyen5 Apr 9, 2018

dternyak commented Apr 12, 2018 •

edited

Loading

wbobeirne left a comment

wbobeirne Apr 12, 2018

wbobeirne Apr 12, 2018

wbobeirne Apr 12, 2018

wbobeirne Apr 12, 2018

josipbagaric Apr 13, 2018

wbobeirne Apr 12, 2018

wbobeirne Apr 12, 2018

e00dan Apr 13, 2018

wbobeirne left a comment

HenryNguyen5 Apr 14, 2018

josipbagaric Apr 14, 2018

HenryNguyen5 Apr 14, 2018

Ethereum Alarm Clock Integration #1343

Ethereum Alarm Clock Integration #1343

Conversation

e00dan commented Mar 19, 2018 • edited Loading

Description

Changes

Steps to Test

Screenshots

tayvano commented Apr 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dternyak commented Apr 12, 2018 • edited Loading

wbobeirne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wbobeirne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

e00dan commented Mar 19, 2018 •

edited

Loading

tayvano commented Apr 5, 2018 •

edited

Loading

dternyak commented Apr 12, 2018 •

edited

Loading