-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging into master
to change base branch
#2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix StoreProvider Bugs
…issues Added support for storing multiple EthersJS singletons
ev/wallet types
…sset-mapping Fixed a few issues with new test assets
…d-validation-functions Unit tests for send form validation functions
…ssets Update rate polling worker on asset updates
release/1.7.3
…nd-assets Fixed back button in Send Assets panel
…tnets Fixed missing gas text when sending testnet assets
…accounts Added route redirection for pages with required accounts
Strip Redux/Shepherd out of HD wallet types in Add Account
Removed shepherd from web3 walletservice
…egacy-code Removed a bunch of shepherd legacy code
ev/merge gau into develop
Staging build: MyCryptoBuilds |
vilsbole
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're migrating our default base branch to be
master
instead ofdevelop
.The production codebase (currently hosted at https://mycrypto.com) will be using the
legacy
branch as it's base branch for the time being. The gau codebase (currently hosted at https://beta.mycrypto.com) will be using themaster
branch as it's base.