Remove Bity Rates from Local Storage #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dternyak
reviewed
Nov 21, 2017
common/store.ts
Outdated
| @@ -111,12 +111,13 @@ const configureStore = () => { | |||
| languageSelection: state.config.languageSelection, | |||
| customNodes: state.config.customNodes | |||
| }, | |||
| swap: state.swap, | |||
| swap: { ...state.swap, bityRates: swapInitialState.bityRates }, | |||
There was a problem hiding this comment.
This still persists state.
bityRates: null is what you're looking for.
dternyak
changed the title
james-prado
requested review from
wbobeirne,
eddiewang,
HenryNguyen5 and
dternyak
james-prado
added
the
status: ready for review
dternyak
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MyEtherWallet/MyEtherWallet#392
swap.bityRateswith initial value when storing in local storagestate.bityRatesfrom{}tonullbityRates no longer persist in localstorage and are updated on each page load.