Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll up animation glitch on mobile #1358

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

hsurf22
Copy link
Contributor

@hsurf22 hsurf22 commented Aug 14, 2019

Bug

https://www.youtube.com/watch?v=DtZELipnn7M

@hsurf22 hsurf22 added the Ready Tag for when a PR is ready to merge label Aug 14, 2019
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #1358 into develop will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1358      +/-   ##
===========================================
+ Coverage    20.83%   20.94%   +0.11%     
===========================================
  Files          330      330              
  Lines         8798     8798              
  Branches      1598     1598              
===========================================
+ Hits          1833     1843      +10     
+ Misses        6462     6454       -8     
+ Partials       503      501       -2
Impacted Files Coverage Δ
src/components/ScrollUpButton/ScrollUpButton.vue 100% <100%> (ø) ⬆️
src/partners/kyber/kyber.js 28.01% <0%> (+3.86%) ⬆️
src/partners/kyber/kyber-calls.js 50% <0%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f7bf6...1584213. Read the comment docs.

@gamalielhere gamalielhere merged commit bfe58a0 into develop Aug 16, 2019
@gamalielhere gamalielhere deleted the bugfix/scroll-top-animation-glitch branch August 16, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants